-
Notifications
You must be signed in to change notification settings - Fork 434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change background color #94
Comments
I need to know too. Actually, I'd like to put one loading indicator.How Can i do this? |
I created a fork of the repo with the background color set to white if anybody is interested |
I think this is a great point, we still need this. |
Fixed in 848bcdf |
Thank you! |
Why was the color changed to white? Most other apps use black. Like Facebook and Whatsapp. |
This seems an odd fix. I think the original issue was requesting a configurable background colour, not a global change to a different unconfigurable one. I came here looking for a way to change it away from black myself, but I do think black is a good default value. |
For anyone finding this issue: I've patched my own copy of react-native-photo-view by changing the colour in RNPhotoView.m to |
How is it now? Because I've got black background, but actually I prefer white one... |
Still cannot change background color for iOS, Android is working fine... |
+1 - we need a fix for this. |
+1 |
It does work You need to uninstall the app from your simulator and also in package.json install directly from the github repo
then reinstall the app on your simulator good to go |
Solved By changing at RNPhotoView.m:
|
@esdrasetrenne 's solution works fine. I did this to "freeze" the version I depend on to today's
But it would be great to release today's |
I did PR #172, for release purpose, I increased minor instead of patch because there were other changes since last npm release (1.5.2). |
Is there a way to change the background color of the photo view for iOS? Currently it is black.
The text was updated successfully, but these errors were encountered: