Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

interfacez_io.vhd address match is using a cryptic address match condition #82

Open
sky-ruimartins opened this issue Apr 22, 2021 · 1 comment
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@sky-ruimartins
Copy link

sky-ruimartins commented Apr 22, 2021

if adr_i(0)='1' and adr_i(1)='1' and adr_i(5)='1' and adr_i(7)='0' then

Instead of using:
if adr_i(0)='1' and adr_i(1)='1' and adr_i(5)='1' and adr_i(7)='0' then

define constantes for a MASK and MATCH value, so that these magic numbers disappear and it becomes easier to read.

@sky-ruimartins sky-ruimartins changed the title interfacez_io.vhd address match is using a cryptic match condition interfacez_io.vhd address match is using a cryptic address match condition Apr 22, 2021
@alvieboy alvieboy self-assigned this Apr 28, 2021
@alvieboy alvieboy added the enhancement New feature or request label Apr 28, 2021
@alvieboy alvieboy added this to the RELEASE_A2 milestone Apr 28, 2021
@alvieboy
Copy link
Owner

Will also restructure the packages so that we have only a single port listing instead of two like we have right now.
The matches will also use a different approach, by using "x" placeholders instead of value/mask pairs. This makes them easier to read and less error prone (at least one of the masks seems to be currently incorrect)

alvieboy added a commit that referenced this issue Apr 28, 2021
alvieboy added a commit that referenced this issue Apr 28, 2021
alvieboy added a commit that referenced this issue Apr 28, 2021
alvieboy added a commit that referenced this issue Apr 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants