Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crash from bad inputs to VGA library functions #25

Open
Jaxartes opened this issue Jan 9, 2016 · 0 comments
Open

crash from bad inputs to VGA library functions #25

Jaxartes opened this issue Jan 9, 2016 · 0 comments

Comments

@Jaxartes
Copy link

Jaxartes commented Jan 9, 2016

A crash sometimes occurs in the "ZPUino_VGA_Adapter/Demo" example code, because it can (depending on screen dimensions) pass out-of-bounds values to gfx.fillRect() and gfx.fillRoundRect() and this results in writing to memory outside the screen area.

It's subject to debate whether this should be fixed in library functions should fix this by checking their inputs (which may have a performance impact) or the "ZPUino_VGA_Adapter/Demo" example by avoiding the bogus values. Or both.

It doesn't always happen, it's one of those "Heisenbugs" which appear/disappear randomly as a result of any changes made in the code. I saw this bug on a Papilio Pro with 800x600 graphics after applying my own workaround to issue #24.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant