Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block quote formatting in distill-style posts #2458

Open
2 tasks done
albertfgu opened this issue May 28, 2024 · 5 comments
Open
2 tasks done

Block quote formatting in distill-style posts #2458

albertfgu opened this issue May 28, 2024 · 5 comments

Comments

@albertfgu
Copy link

albertfgu commented May 28, 2024

Have you checked that your issue isn't already filed?

  • I read through FAQ and searched through the past issues, none of which addressed my issue.
  • Yes, I have checked that this issue isn't already filed.

Bug description

Block quotes aren't formatted properly in distill-style blog posts

How to reproduce the bug

The example blog post with block quotes gives this example

> ##### TIP
>
> A tip can be used when you want to give advice
> related to a certain content.
{: .block-tip }

which is displayed as:
image

However, the same example in a distill-style blog post looks like:
image

The former looks much better: Ideally at least, block quotes would support headers that are non-italicized and colored.

(Personally, I think that having the entire quote in non-italics is nicer, but at least the header should be formatted)

Error messages and logs

No response

What operating system are you using?

Mac

Where are you seeing the problem on?

Running locally without Docker

More info

No response

@scottleechua
Copy link
Contributor

@george-gca hello! 👋

as a long-time al-folio user I'm looking to start contributing back and want to help with this issue.

I do agree with having formatting consistency between distill and non-distill posts, but this would mean hand-tweaking the CSS in template.v2.js and transforms.v2.js.

Is this advisable? Are those autogenerated files? Is formatting parity between distill and non-distill a goal for this theme?

@george-gca
Copy link
Collaborator

I believe at least for the main parts (like code theme, block quote, maybe others) this is advisable. As for hand-tweaking their CSS, maybe we could add a new scss file that will be imported only in the distill layout overriding the specific rules. This way we don't have to mess inside these files, just look at which overrides will be made.

The distill template works as in this guide, simply by importing these files. These files were probably auto generated a long time ago, since their repository doesn't see an update in years and neither their site. They even posted about taking a long hiatus. So I think it is safe to say that they won't change for the foreseeable future too.

@scottleechua
Copy link
Contributor

Got it! How have you and the maintainers thought about feature parity between the two kinds of post layouts, standard and distill?

For instance, creating tabs in posts works in standard but not distill.

I've had a quick skim of the post features, and the two that make sense to me to support in distill posts are

  1. custom blockquotes, and
  2. posts that can be cited.

What do you think? I'm happy to open a PR for the two listed above. I just realize it might be good to establish what features are supported where.

@george-gca
Copy link
Collaborator

I believe it would be useful to support all (if not most) features already implemented for regular posts in the distill template, unless it conflicts with it (for example, the table of contents, or we can have another look at it). At least I see the distill template as a basic template that we shoould customize as we wish.

What do you guys thin @alshedivat, @pourmand1376?

Copy link

stale bot commented Sep 13, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants