Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run valgrind memcheck in CI #54

Open
nopeslide opened this issue Aug 2, 2020 · 2 comments
Open

Run valgrind memcheck in CI #54

nopeslide opened this issue Aug 2, 2020 · 2 comments

Comments

@nopeslide
Copy link
Collaborator

I found a few memory errors with valgrind in the base code.
To prevent such things in the future I propose running all tests with valgrind

@alrevuelta
Copy link
Owner

Yes, this is something that was definitely missing. Which specific memory errors you had?

@nopeslide
Copy link
Collaborator Author

nopeslide commented Aug 3, 2020

Yes, this is something that was definitely missing. Which specific memory errors you had?

you duplicate a string when integrating the input into the model.
this string had a fixed allocation size of 50 and it seems some model or input had a longer name :D
I implemented some std string utilities (strnlen,strdup, strndup) to replace this allocation in #53.
see 6705c6f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants