New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Two missing null check for return values of searchAttributeNyName() #102

Open

szsam opened this issue Jun 5, 2023 · 0 comments

szsam commented Jun 5, 2023

The result of these calls to searchAttributeNyName is not checked for null, but 92% of calls to searchAttributeNyName check for null.

cONNXr/src/operators/ai.onnx/Constant/12/prepare_operator__ai_onnx__constant__12.c

Line 19 in 7108b7b

    
           Onnx__AttributeProto *a_value = searchAttributeNyName(ctx->onnx_node->n_attribute,ctx->onnx_node->attribute,"value");

cONNXr/src/operators/ai.onnx/MaxPool/12/prepare_operator__ai_onnx__maxpool__12.c

Line 26 in 7108b7b

    
           Onnx__AttributeProto *a_kernel_shape = searchAttributeNyName(ctx->onnx_node->n_attribute,ctx->onnx_node->attribute,"kernel_shape");

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment