Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lexical query not found: different result in double-click vs wordlist #341

Open
monzug opened this issue Dec 1, 2021 · 3 comments
Open

Comments

@monzug
Copy link

monzug commented Dec 1, 2021

doing regression, so double clicking on several latin worlds. just realized that Accius and Varro from https://www.loebclassics.com/view/accius-by_works/1936/pb_LCL314.593.xml?rskey=p6oWMl&result=3 give a different result than same words from wordlist.

Accius from double click and lookup
Screen Shot 2021-12-01 at 2 20 21 PM

Accius from wordlist
Screen Shot 2021-12-01 at 2 20 10 PM

while Parergorum gives same result from double click and from wordlist: lexical query produced no results.
an other inconsistency, @irina060981

@irina060981
Copy link
Member

I found the reason.
If you click on Parergorum , then results would be the same from double click on page and double click .
image

But as for Varro or Accius we see difference.
The reason:
Varro and Accius have full definitions that is ready after Lexical query produced no results is published.
And we don't have a trigger that removes it.

But when you select such words from wordlist , than it has already full definitions and doesn't print this message.

I could suggest one of two solutions:

  1. add a trigger - remove message when full definitions are recieved
  2. remove condition about full definitions for the message -> then if a homonym has only full definitions, message would be printed anyway

@monzug , what do you think?

@monzug
Copy link
Author

monzug commented Dec 2, 2021

I noticed the full definition icon as the only difference between accius and words such as perergorum. I would not take any action at the moment but keep it alive for future releases. Thanks so much for digging into it!!!

@irina060981
Copy link
Member

ok

@irina060981 irina060981 removed their assignment Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants