Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error message in Chrome/PC #323

Open
monzug opened this issue Jun 23, 2021 · 9 comments
Open

Fix error message in Chrome/PC #323

monzug opened this issue Jun 23, 2021 · 9 comments
Assignees
Labels

Comments

@monzug
Copy link

monzug commented Jun 23, 2021

  1. I noticed that I am getting a message in Chrome/PC that is missing in Chrome/Mac (I do have the tools installed on both). If I click on the tools icon, I see Alpheios Extension Disabled for Page on MAC. Why such a difference between PC and MAC? see PC message below and screenshot

This pages embeds Alpheios directly. The Alpheios browser extension is not needed for it and will be deactivated until you navigate away from the page

  1. Could you please improve the message by removing the plural on pages? Could you just say: Alpheios Extension Disabled for the Page as it's on Mac?

embedded-tool

@irina060981
Copy link
Member

This question is not related to the AlignmentEditor - it is the behaviour defined in the webextension - separately for Safari Extension and Chrome/Firefox Extension.
The diffrence is from the way each extension communicate with the browser.

If we want to change anything inside webxtensions - we need to rebuild it and then publish it again to the stores.
I don't think that it is a good moment for this - I will move this issue to the webextension repo and close this one.

May be when we continue to work on extensions in future (or not we :) ) - developers would be able to solve this task.

@irina060981 irina060981 removed their assignment Jul 3, 2021
@irina060981 irina060981 reopened this Jul 3, 2021
@irina060981 irina060981 transferred this issue from alpheios-project/alignment-editor-new Jul 3, 2021
@monzug
Copy link
Author

monzug commented Jul 5, 2021

Irina, is there a way for you to fix issue 2) above: Could you please improve the message by removing the plural on pages? Could you just say: Alpheios Extension Disabled for the Page as it's on Mac?

right now it says This pages should be this page

@monzug monzug added the bug label Jul 5, 2021
@monzug monzug changed the title Question on embedded tools on PC vs MAC Fix error message in Chrome/PC Oct 29, 2021
@irina060981
Copy link
Member

First of all I was not able to reproduce this message.
I tried to activate alpheios extension on (used alignment editor it embeds Alpheios Tools directly)

  1. Chrome/PC - It simply adds it twice and we again have multiple popups
  2. Firefox/PC - the same - adds twice
  3. Chrome/MAc - the same - adds twice
  4. Firefox/Mac - the same - adds twice

So I don't know how it works before - but now the checking mechanism doesn't work
And it is really sad

@monzug
Copy link
Author

monzug commented Nov 24, 2021

I was able to reproduce it in Chrome/PC and also FF/PC. see version of webextension and the error.
to repro. I reload alignment editor with web extension on, I select an idexedDB file from splash screen. as soon as I go to the align text, the message is printed on top of the page
error-alpheios

@monzug
Copy link
Author

monzug commented Nov 24, 2021

this is in Chrome/Mac. I was able to get the same message in FF/Mac too.
Screen Shot 2021-11-24 at 3 35 15 PM

@irina060981
Copy link
Member

I was able tro get this message on PC/Chrome

But also it has 2 extensions attached

image

Anyway I would investigate it, but according to the issue

above: Could you please improve the message by removing the plural on pages? Could you just say: Alpheios Extension Disabled for the Page as it's on Mac?
right now it says This pages should be this page

This message could be generated (by its workflow) on PC/MAC anad CHrome/Firefox
So I couldn't rename the message to

Alpheios Extension Disabled for the Page as it's on Mac

Because it is not true.
But I could change this pages -> this page.

@irina060981
Copy link
Member

Message is updated to

This page embeds Alpheios directly. The Alpheios browser extension is not needed for it and will be deactivated until you navigate away from the page.

@monzug
Copy link
Author

monzug commented Nov 29, 2021

message has been updated, see attachment
Screen Shot 2021-11-29 at 2 40 21 PM

@irina060981 this works fine in the alignment editor except for the splash screen where I can disable the tools by clicking on the Alpheios icon from the toolbar. then when I resume an existing alignment the tools are automatically turned on.
My understanding is that tools are embedded in the application so I should not be able to turn on|off. am I correct?

@irina060981
Copy link
Member

Alpheios icon from the toolbar. then when I resume an existing alignment the tools are automatically turned on.
My understanding is that tools are embedded in the application so I should not be able to turn on|off. am I correct?

No, it is not true.
It works the following way:

  • when embed-lib is registered on the page it sends a message to the attached extension
  • if extension is active - a message would be printed and it would be automatically turned off

And that's all that is done here. Nothing else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants