Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logic for traditional/simplified lookup needs tweaking #10

Open
balmas opened this issue Jan 28, 2020 · 2 comments
Open

logic for traditional/simplified lookup needs tweaking #10

balmas opened this issue Jan 28, 2020 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@balmas
Copy link
Member

balmas commented Jan 28, 2020

Since many or most characters are both, I'm not sure how you can use the presence of ANY selected character in the traditional index as indicating that the rest are traditional.

Hmm. This is a good point. I think the logic needs a little tweaking here. It works if nothing is found in the traditional index, because it will fall back to simplified, but if the first character is both traditional and simplified, we could be missing things in the forward context.

Originally posted by @balmas in https://github.com/alpheios-project/components/issues/892#issuecomment-579386830

@balmas balmas added the bug Something isn't working label Jan 28, 2020
@balmas
Copy link
Member Author

balmas commented Jan 28, 2020

the comment from @abrasax made me realize we need to fix our logic here.

If the first character in a lookup is both traditional and simplified, then we cannot make an assumption about what the subsequent characters are.

@balmas
Copy link
Member Author

balmas commented Mar 26, 2020

@kirlat let me know if the request isn't clear.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants