You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I was documenting the finder schema and found a few things that seem redundant/not-utilised.
I'm wondering if we can remove "search" as a document type. Initially, "search" was specified as a document type to ensure the advanced search finder wasn't indexed. By giving it this document type, we could prevent the /search/advanced finder from being indexed. However, it appears that this finder is no longer in use, as indicated by this commit.
'No_index'. I was only able to find one instance of this property being used. It also seems like it was only used for Brexit, so I'm wondering if it is still relevant.
'Generic_description'. The only trace I could find of this in use was in this commit, in which it is being removed. It looks like it was used for Brexit, so I again am wondering if we still need it.
'Logo_path'. It doesn't appear that this property is widely used, it was introduced in this PR from 2015. I assume this is very outdated now, so again i'm wondering if we can get rid.
'Canonical_link'. This one again looks outdated, and doesn't seem widely used.
The text was updated successfully, but these errors were encountered:
I was documenting the finder schema and found a few things that seem redundant/not-utilised.
I'm wondering if we can remove "search" as a document type. Initially, "search" was specified as a document type to ensure the advanced search finder wasn't indexed. By giving it this document type, we could prevent the /search/advanced finder from being indexed. However, it appears that this finder is no longer in use, as indicated by this commit.
'No_index'. I was only able to find one instance of this property being used. It also seems like it was only used for Brexit, so I'm wondering if it is still relevant.
'Generic_description'. The only trace I could find of this in use was in this commit, in which it is being removed. It looks like it was used for Brexit, so I again am wondering if we still need it.
'Logo_path'. It doesn't appear that this property is widely used, it was introduced in this PR from 2015. I assume this is very outdated now, so again i'm wondering if we can get rid.
'Canonical_link'. This one again looks outdated, and doesn't seem widely used.
The text was updated successfully, but these errors were encountered: