Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE] Upgrade version of graphql-core to >3.0.0 without breaking github_security audit events ^ #603

Open
gds-ahine opened this issue Jun 2, 2021 · 1 comment
Assignees
Labels
blocked bug Something isn't working In Jira

Comments

@gds-ahine
Copy link
Contributor

gds-ahine commented Jun 2, 2021

This shouldn't be merged until we can also upgrade to gql:3 currently in alpha

Dependabot alert to bump the version of graphql-core broke the github audit events.

We reverted back to <3.0.0 but we should look into upgrading to resolve the following issues -:

#572

graphql-python/graphql-core#125
graphql-python/graphql-core#126

@gds-ahine gds-ahine added the bug Something isn't working label Jun 2, 2021
@danjoneslf danjoneslf self-assigned this Jun 8, 2021
@LauraChilcott LauraChilcott changed the title Upgrade version of graphql-core to >3.0.0 without breaking github_security audit events Upgrade version of graphql-core to >3.0.0 without breaking github_security audit events ^ Jun 8, 2021
@danjoneslf
Copy link
Contributor

Unfortunately we can't implement this at present. The gql library calls a function of graphql-core which has been removed in later versions. There is an equivalent function in 3.* releases but there's not yet a newer release of gql implementing the change.

There is an alpha of gql:3 which addresses this: graphql-python/gql#62 - In alpha in Sep 2020

@danjoneslf danjoneslf changed the title Upgrade version of graphql-core to >3.0.0 without breaking github_security audit events ^ [DO NOT MERGE] Upgrade version of graphql-core to >3.0.0 without breaking github_security audit events ^ Jun 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked bug Something isn't working In Jira
Projects
None yet
Development

No branches or pull requests

4 participants