Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unnecessary field in auth data flow #3

Open
Muhammedijas981 opened this issue Mar 7, 2023 · 2 comments
Open

Unnecessary field in auth data flow #3

Muhammedijas981 opened this issue Mar 7, 2023 · 2 comments
Assignees
@vishalkrishnads
Labels
enhancement New feature or request

Comments

@Muhammedijas981
Copy link
Member

Muhammedijas981 commented Mar 7, 2023 •
edited
Loading

unnecessary user name field
@Muhammedijas981
Copy link
Member Author

As per the new UI in app, the username field in the auth data seems unnecessary. It just simply complicates things I'd say. Moreover, I have noted that the server doesn't check for uniqueness when asking with a new username. Wouldn't it be better to just remove it? 🤔

Or else you'd have to work on a new websocket endpoint to check for username uniqueness. User auth isn't the point of this project anyway, so I feel we'd be better off without this.

@vishalkrishnads vishalkrishnads changed the title unnecessary user name field Unnecessary field in auth data flow Mar 8, 2023
@vishalkrishnads
Copy link
Member

Yeah you're right.. working on it

@vishalkrishnads vishalkrishnads self-assigned this Mar 8, 2023
@vishalkrishnads vishalkrishnads added the enhancement New feature or request label Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vishalkrishnads vishalkrishnads

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vishalkrishnads @Muhammedijas981