chore: rm execution requests from v4 payload fn #401
Conversation
|
conflicts with spec ethereum-optimism/specs#525 |
|
hm, though this isn't an rpc api...so it could be ok to remove the arg...in rpc it breaks spec though |
what am I missing here? |
|
An empty requests array keeps the API more compatible with that of L1, and the diff smaller. Op-stack only adds optional attributes, and doesn't remove any from the API definition. E.g. in geth it may sanity-check it's present if Pectra is active: that doesn't have to change if it's simply an empty array. Also, removing it now will make it harder to utilize when we later do see a good use for the EL-requests in OP-Stack. |
|
Since this is op-specific, I think it makes sense to remove the param from the public interface (but obviously still send it over RPC). This LGTM! I think we should still validate that these are empty arrays when receiving a v4 request though - which I believe will be implemented in reth? |
closes #395