WIP Get a test working

Author: wbharding

lib/plugin.js

@@ -1,8 +1,8 @@
 const plugin = {
   constants: {
     booksImportedLabel: "Readwise books imported into table",
-    breakToDecadeBookCount: 10,
-    breakToYearBookCount: 50,
+    breakToDecadeBookCount: 3,
+    breakToYearBookCount: 6,
     defaultBaseTag: "library",
     dashboardBookListTitle: "Readwise Book List",
     defaultDashboardNoteTitle: "Readwise Library Dashboard",
@@ -12,7 +12,7 @@ const plugin = {
     lastUpdatedContentLabel: "Next sync for content updated after: ",
     maxReplaceContentLength: 100000, // Empirically derived
     maxHighlightLimit: 5000,
-    rateLimit: 20, // Max requests per minute (20 is Readwise limit for Books and Highlights APIs)
+    rateLimit: 2, // Max requests per minute (20 is Readwise limit for Books and Highlights APIs)
     readwiseBookDetailURL: bookId => `https://readwise.io/api/v2/books/${ bookId }`,
     readwiseBookIndexURL: "https://readwise.io/api/v2/books",
     readwiseHighlightsIndexURL: "https://readwise.io/api/v2/highlights",
@@ -108,8 +108,12 @@ const plugin = {
           await app.alert(`✅ ${ bookCount } book${ bookCount === "1" ? "" : "s" } fetched & refreshed successfully!`);
         }
       } catch (error) {
-        await app.alert(String(error));
-        this._abortExecution = true;
+        if (this._testEnvironment) {
+          throw(error);
+        } else {
+          await app.alert(String(error));
+          this._abortExecution = true;
+        }
       }
     },
 
@@ -898,5 +902,7 @@ const plugin = {
     this._forceReprocess = false;
     this._lastRequestTime = null;
     this._requestsCount = 0;
+    if (this._testEnvironment === undefined) this._testEnvironment = false;
   }
 }
+export default plugin;

lib/plugin.test.js

@@ -1,6 +1,8 @@
 import { jest } from "@jest/globals"
 import { mockPlugin, mockApp } from "./test-helpers.js"
 
+import plugin from "./plugin.js"
+
 // --------------------------------------------------------------------------------------
 // Note that some of these tests actually make calls to OpenAI. Normally tests would be mocked for
 // a remote call, but for Bill's current purposes, it's pretty useful to be able to see what the real
@@ -12,28 +14,39 @@ describe("plugin", () => {
   describe("with a mocked app", () => {
     const app = mockApp();
 
-    it("should look up thesaurus entries from trivial input", async () => {
-      const noteContent = `
-        Author: Leo Tolstoy
-        Title: War and Peace
-        Date: 1869
-        Book ID: 23
+    it("should evaluate the lookup expression", async () => {
+      const noteUUID = 123;
+      const readwiseID = 456;
+      const content = `
+# Library Details
+Last synced at: June 15, 2023 3:39 PM
+Oldest update synced in: August 5, 2022
+Next sync for content updated after: August 5, 2022
+Readwise books imported into table: 18
+Book count reported by Readwise: 25
 
-        ### Yo mama so fat, she a multi-part download
-        Highlighted at: January 3, 2021 12:00 AM
-        Readwise URL: https://readwise.io/abc123 
-      `;
-      const noteHandles = [ { name: "War and Peace by Tolstoy (R-ID #23)", uuid: "abc123" } ];
-      app.notes.filter = jest.fn().mockResolvedValue(noteHandles)
-      app.getNoteContent = jest.fn().mockResolvedValue(noteContent);
-      await plugin.noteOption["Sync Readwise"](app, "abc123");
-    });
+# ${ plugin.constants.dashboardBookListTitle }
+${ plugin._tablePreambleContent() }
+| ![book cover](https://www.gitclear.com/image.jpg) | William Harding | books | [kindle](https://kindle.com/blah) | [5 highlights](https://amplenote.com/notes/abc333) | August 5, 2022 | [Readwise link](${ readwiseID }) |
+| ![book cover](https://www.gitclear.com/image.jpg) | William Harding | books | [kindle](https://kindle.com/blah) | [5 highlights](https://amplenote.com/notes/abc333) | August 5, 2022 | [Readwise link](999) |
+`
+      const noteHandle = {
+        content: () => content,
+        name: plugin.constants.defaultDashboardNoteTitle,
+        uuid: noteUUID,
+      };
+      app.findNote = jest.fn().mockResolvedValue(noteHandle);
+      app.notes.find = jest.fn().mockResolvedValue(noteHandle);
+      app.getNoteContent = jest.fn().mockResolvedValue(content);
+      plugin._readwiseMakeRequest = jest.fn().mockResolvedValue({ count: 0 });
+      async function* getBook() {
+        yield* ({ something: "for sure" })
+      }
+      plugin._readwiseFetchBooks = getBook.bind(plugin);
+      plugin._testEnvironment = true;
 
-    it("should evaluate the lookup expression", async () => {
-      app.notes.find.mockReturnValue({
-        content: () => `To be, or not to be, that is the {${ plugin.constants.pluginName }: lookup}.`
-      });
-      const result = await plugin.insertText.lookup(app);
+      app.notes.find.mockReturnValue({ content: () => content });
+      const result = await plugin.noteOption["Sync all"](app, noteUUID);
       expect(result).toBe("question.");
     });
   });

package-lock.json

@@ -7,13 +7,15 @@
   "devDependencies": {
     "@types/jest": "^29.5.0",
     "jest": "^29.5.0",
+    "jest-environment-jsdom": "^29.5.0",
     "ts-jest": "^29.1.0"
   },
   "main": "lib/index.js",
   "name": "yappy",
   "scripts": {
     "test": "jest"
   },
+  "testEnvironment": "jsdom",
   "type": "module",
   "version": "0.1.1"
 }