-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Semantic HTML in generated report page #2742
Comments
Thanks for reaching out! I’m totally up for any improvements that could make the report better, as long as they don’t break its current functionality :) Feel free to share any ideas you have about the changes. |
There are two types of accessibility changes that come to mind first:
Item one wouldn't modify any scripts while item two would involve some One quick question: do you have a minimum browser version to target for the report, or would you like me to choose one? That will affect the way some of the above changes get implemented. |
That sounds great! I don’t have a specific browser version to target, however, as long as it works on recent versions of any major browsers, I’m fine. Thanks for your help! |
The most straightforward way to improve semantics for the "Panel options" dropdown would involve swapping out the Font Awesome icon indicators with native form controls, essentially pulling out that component and recreating it from scratch. Would you like a change that large to be a separate pull request from the general semantic improvements, or can it be included in this work? |
That's a good point, I'd rather have it as a separate PR from the overall semantic improvements. |
Would you be open to a merging a pull request that updated the generated HTML reports to use semantic HTML? I wanted to gauge interest before taking a crack at it.
The text was updated successfully, but these errors were encountered: