Ensure that the Expand button is not copied when clicking the copy button (#25)

Author: srtfisher

CHANGELOG.md

@@ -2,6 +2,10 @@
 
 All notable changes to `meta-inspector` will be documented in this file.
 
+## 1.1.2 - 2024-01-08
+
+- Fix issue with the "Expand" button being copied when clicking the "Copy" button.
+
 ## 1.1.1 - 2023-06-28
 
 - Add click to copy functionality to the meta keys and values.

inc/class-table.php

@@ -120,8 +120,8 @@ function ( $row ) {
 	 */
 	public static function get_max_pre_height(): int {
 		/**
-		 * Filter the max height of a pre element before it is collapsed (in
-		 * pixels) with a default of 400 and a minimum of 100.
+		 * Filter the max height of a pre element before it is collapsed
+		 * (in pixels) with a default of 400px and a minimum of 100px.
 		 *
 		 * @param int $max_pre_height The max height of a pre element before it is collapsed.
 		 */
@@ -224,11 +224,13 @@ public static function output_footer(): void {
 				var copyButtons = document.querySelectorAll('.meta-inspector button.copy-button')
 				copyButtons.forEach(function(button) {
 					button.addEventListener('click', function (event) {
-						navigator.clipboard.writeText(this.parentNode.innerText);
+						var pre = this.parentNode.querySelector('pre');
+
+						navigator.clipboard.writeText(pre ? pre.innerText : this.parentNode.innerText);
 						this.classList.add('copied');
 
 						var previousLabel = this.getAttribute('aria-label');
-						this.setAttribute('aria-label', <?php echo wp_json_encode( esc_attr__( 'Copied', 'meta-inspector' ) ); ?>);
+						this.setAttribute('aria-label', <?php echo wp_json_encode( __( 'Copied', 'meta-inspector' ) ); ?>);
 
 						setTimeout(function() {
 							button.classList.remove('copied');
@@ -242,7 +244,7 @@ public static function output_footer(): void {
 				// Collapse pre elements that are taller than the max height.
 				document.querySelectorAll('.meta-inspector pre').forEach(function(pre) {
 					var expandLink = pre.parentNode.querySelector('.expand-link');
-					console.log('pre', jQuery(pre).height(), maxPreHeight);
+
 					if (pre.clientHeight < maxPreHeight) {
 						// Remove the expand link if the pre element is not tall enough.
 						if (expandLink) {

meta-inspector.php

@@ -3,10 +3,9 @@
  * Plugin Name:     Meta Inspector
  * Description:     View various types of meta data about WordPress objects to assist debugging.
  * Author:          alleyinteractive, jameswalterburke
- * Author URI:      https://alley.com
+ * Author URI:      https://alley.com/
  * Text Domain:     meta-inspector
- * Domain Path:     /languages
- * Version:         1.1.1
+ * Version:         1.1.2
  *
  * @package         Meta_Inspector
  */