Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a check for WP_IMPORTING before publishing or syncing #997

Open
emilyatmobtown opened this issue Mar 10, 2023 · 0 comments
Open

Add a check for WP_IMPORTING before publishing or syncing #997

emilyatmobtown opened this issue Mar 10, 2023 · 0 comments
Labels
enhancement New feature or request php Requires understanding PHP

Comments

@emilyatmobtown
Copy link

emilyatmobtown commented Mar 10, 2023

Migrations and bulk CLI commands often trigger post updates. These can inadvertently trigger a publish or sync to Apple News without careful filtering. While the plugin does have filters to skip the publish/sync, a helpful enhancement would be to add a check for WP_IMPORTING before publishing/syncing. This aligns with best practices to ensure that third-party integrations are not triggered during bulk updates and it supports the developer experience by offering a simplified and universal approach.

Acceptance Criteria

  • Create a filter that defaults to the value of WP_IMPORTING if it is set (or false if not) which will skip any pushes to Apple News, including article creation, updates, and deletes.
  • Add a test for this new functionality.
@kevinfodness kevinfodness added the enhancement New feature or request label Apr 27, 2023
@attackant attackant added this to the v2.4.7 milestone Feb 2, 2024
@kevinfodness kevinfodness removed this from the v2.4.7 milestone May 10, 2024
@kevinfodness kevinfodness added php Requires understanding PHP and removed evaluating labels Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request php Requires understanding PHP
Projects
None yet
Development

No branches or pull requests

3 participants