Set proper metric name depending on vcl reload result (#504)

allegro · Oct 17, 2023 · 70f8e68 · 70f8e68
1 parent e050909
commit 70f8e68
Showing 1 changed file with 1 addition and 4 deletions.
diff --git a/vaas/vaas/cluster/cluster.py b/vaas/vaas/cluster/cluster.py
@@ -114,10 +114,7 @@ def load_vcl(self, start_processing_time, clusters):
             self._handle_load_error(e, clusters, start_processing_time)
         else:
             result = parallel_loader.use_vcl_list(start_processing_time, loaded_vcl_list)
-            if result is False:
-                metrics.counter('reload_vcl.status.success')
-            else:
-                metrics.counter('reload_vcl.status.failed')
+            metrics.counter('reload_vcl.status.success' if result else 'reload_vcl.status.failed')
             return result
         finally:
             for phase, processing in processing_stats.items():