Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify API #21

Open
ghost opened this issue May 13, 2015 · 4 comments
Open

Simplify API #21

ghost opened this issue May 13, 2015 · 4 comments

Comments

@ghost
Copy link

ghost commented May 13, 2015

  1. tile and key API params could be included in JSON data.
  2. Now API has 2 resources one for config, one for data. Config data and tile data could be simply in the same JSON data.
@ghost ghost added the enhancement label May 13, 2015
@xor-xor
Copy link
Contributor

xor-xor commented May 13, 2015

👍

@RickyGrassmuck
Copy link

Saw you had this issue open, I just patched tipboard to use a single JSON object for retrieving the tile, key and data. Want me to submit a pull request so you can look it over?

@ghost
Copy link
Author

ghost commented Jan 30, 2017

Sure, I'd like to take a look :)

@the-maux
Copy link

the-maux commented Aug 6, 2019

On my PR #70 i resolved this issue with a /update

For example, before, your data for the request was:

  var = {"tile": "big_value",
           "key":  "mybigvalue",
           "data": {"title": "% of something",
                               "description": "% of subtitle",
                               "big-value": "50%",
                               "lower-left-label": "title_value1:",
                               "upper-left-label": "title_value2:",
                               "upper-right-label": "value1",
                               "lower-right-label": "value2"}
         }

It's now:

  var = {"tile": "big_value",
           "key":  "mybigvalue",
           "value": {"big_value_color": "green", "fading_background": "true"},
           "data": {"title": "% of something",
                               "description": "% of subtitle",
                               "big-value": "50%",
                               "lower-left-label": "title_value1:",
                               "upper-left-label": "title_value2:",
                               "upper-right-label": "value1",
                               "lower-right-label": "value2"}
           }

Check this out :D

But you can still use the old way of course

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants