Skip to content

Commit 12ae8a1

Browse files
committed
Merge pull request #66 from allegro/fixes_#64_#65_update_readme
Update README.md
2 parents adba646 + eb651a1 commit 12ae8a1

File tree

2 files changed

+37
-11
lines changed

2 files changed

+37
-11
lines changed

.travis.yml

Lines changed: 15 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,25 @@
11
language: go
22

33
go:
4-
- 1.5
4+
- 1.6
55
- tip
66
before_install:
7+
- go get golang.org/x/tools/cmd/cover
78
- go get github.com/axw/gocov/gocov
9+
- go get github.com/modocache/gover
810
- go get github.com/mattn/goveralls
911
- if ! go get github.com/golang/tools/cmd/cover; then go get golang.org/x/tools/cmd/cover; fi
1012
script:
1113
- make deps
12-
- $HOME/gopath/bin/goveralls -package ./... -service=travis-ci
14+
- go test -coverprofile=apps.coverprofile ./apps
15+
- go test -coverprofile=config.coverprofile ./config
16+
- go test -coverprofile=consul.coverprofile ./consul
17+
- go test -coverprofile=events.coverprofile ./events
18+
- go test -coverprofile=marathon.coverprofile ./marathon
19+
- go test -coverprofile=metrics.coverprofile ./metrics
20+
- go test -coverprofile=sync.coverprofile ./sync
21+
- go test -coverprofile=utils.coverprofile ./utils
22+
- go test -coverprofile=web.coverprofile ./web
23+
- go test -coverprofile=main.coverprofile
24+
- $HOME/gopath/bin/gover
25+
- $HOME/gopath/bin/goveralls -coverprofile=gover.coverprofile -service travis-ci

README.md

Lines changed: 22 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,28 @@
44
Register [Marathon](https://mesosphere.github.io/marathon/) Tasks as [Consul](https://www.consul.io/) Services for service discovery.
55

66
`marathon-consul` takes information provided by the [Marathon event bus](https://mesosphere.github.io/marathon/docs/event-bus.html) and
7-
forwards it to Consul agents. It also re-syncs all the information from Marathon
7+
forwards it to Consul agents. It also re-syncs all the information from Marathon
88
to Consul on startup and repeats it with given interval.
99

10+
## Code
11+
12+
This project is based on
13+
14+
* [mesos-consul](https://github.com/CiscoCloud/mesos-consul)
15+
* [marathon-consul](https://github.com/CiscoCloud/marathon-consul)
16+
17+
### Differences
18+
19+
* CiscoCloud/marthon-consul copies application information to Consul KV while
20+
allegro/marathon-consul registers tasks as Consul services
21+
(it is more similar to CiscoCloud/mesos-consul)
22+
* CiscoCloud/mesos-consul uses polling while allegro/marathon-consul uses
23+
[Marathon's event bus](https://mesosphere.github.io/marathon/docs/event-bus.html)
24+
to detect changes
25+
* CiscoCloud/marathon-consul is no longer developed
26+
(see [comment](https://github.com/CiscoCloud/marathon-consul/issues/17#issuecomment-161678453))
27+
28+
1029
## Installation
1130

1231
### Installing from source code
@@ -69,6 +88,7 @@ curl -X POST 'http://marathon.service.consul:8080/v2/eventSubscriptions?callback
6988

7089
## Usage
7190

91+
- marathon-consul should be installed on all Marathon masters, and subscription should be set to `localhost` to reduce network traffic
7292
- Consul Agents should be available at every Mesos Slave, tasks will be registered at hosts their run on.
7393
- Only tasks which are labeled as `consul` will be registered in Consul. By default the registered service name is equal to Marathon's application name.
7494
A different name can be provided as the label's value, e.g. `consul:customName`. As an exception of the rule, for backward compatibility with the `0.3.x` branch, a value of `true` is resolved to the default name.
@@ -130,17 +150,10 @@ The following section describes known limitations in `marathon-consul`.
130150

131151
* Every marathon application needs to have a unique service name in Consul.
132152
* In Marathon when a deployment changing the application's service name (by changing its `labels`) is being stopped, it changes app's configuration anyway.
133-
This means we loose the link between the app and the services registered with the old name in Consul.
153+
This means we loose the link between the app and the services registered with the old name in Consul.
134154
Later on, if another deployment takes place, new services are registered with a new name, the old ones are not being deregistered though.
135155
A scheduled sync is required to wipe them out.
136156

137-
## Code
138-
139-
This project is based on
140-
141-
* [mesos-consul](https://github.com/CiscoCloud/mesos-consul)
142-
* [marathon-consul](https://github.com/CiscoCloud/marathon-consul)
143-
144157
## License
145158

146159
Marathon-consul is released under the Apache 2.0 license (see [LICENSE](LICENSE))

0 commit comments

Comments
 (0)