Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract OneLogin app ID automatically #53

Open
johananl opened this issue Aug 14, 2018 · 4 comments
Open

Extract OneLogin app ID automatically #53

johananl opened this issue Aug 14, 2018 · 4 comments

Comments

@johananl
Copy link
Collaborator

johananl commented Aug 14, 2018

Maybe the OneLogin embedding API can help: https://developers.onelogin.com/api-docs/1/embed-apps/get-apps-to-embed-for-a-user

@johananl johananl changed the title Extract OneLogin app ID from SAML response Extract OneLogin app ID automatically Aug 14, 2018
@ghost
Copy link

ghost commented Dec 11, 2018

As this is one of the most requested features internally, I'll try to advance this.

I wonder if a shared embeddable token is considered a security risk again? @lahavsavir

Compared to the previous internal solution, this removes the possibility to list users but still keeps the possibility to enumerate apps if I know the email addresses of users (which are incredible hard to guess).

Alternatives I see is developing some Lambda that is storing the needed credentials securely and can only be used after authentication (I'd prefer IAM based auth).

@lahavsavir, @johananl WDYT?

@johananl
Copy link
Collaborator Author

johananl commented Dec 11, 2018

Looks like the embed token is much safer than the API credentials, because all it allows you to do is obtain the list of apps. On the other hand, it still allows obtaining a list of apps without providing user credentials, MFA etc. It also allows a user to get a list of apps that are accessible to another user by sending a request to the API with their email address (and the same token), however it won't allow them to get credentials for these apps if they themselves don't have permissions for them.

The question is if the above is acceptable. It might be acceptable for some use cases.

Looks like the embed token is shared by design, i.e. you can't even generate two on a given OneLogin account, only replace the one existing token.

A Lambda-based solution seems outside the scope of Clisso to me. All Clisso provides is an interface to OneLogin/Okta. This could still be a valid solution for specific use cases, however I don't see how Lambda helps us provide a generic solution to the app ID retrieval issue.

REMINDER: This is a public repository now. We should avoid discussing specifics or "internal" stuff. For these we should use other channels. Just a reminder because this discussion could lead to sensitive issues.

@johananl
Copy link
Collaborator Author

How about talking to OneLogin about this use case? We need some solution which would eliminate the need for contacting an admin for every app a user wants to add, without creating huge security risks. They might have an idea. If they don't, we could try pushing towards a new feature.

@lahavsavir
Copy link
Member

lahavsavir commented Dec 11, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants