Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Spinner code to function #101

Open
ghost opened this issue Feb 10, 2021 · 0 comments
Open

Move Spinner code to function #101

ghost opened this issue Feb 10, 2021 · 0 comments
Labels
enhancement

Comments

@ghost
Copy link

ghost commented Feb 10, 2021

With this API for spinner, it would be easy to forget to call Stop() when handling errors and spin forever.

Maybe it could be changed to a function to help you rememeber to clean up?

s.Run(func() {
  // after this runs the spinner is stopped
})

Image of Max H Max H

Originally posted by @pullrequest[bot] in #96 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bitte-ein-bit