barcody.bas won't encode numbers #4
Comments
|
Good catch! I might take some time over Christmas to look into this. If you need it quicker/want to get active yourself, I am sure it is in the same part of the code as the previous bugs I fixed (see https://github.com/jonasheidelberg/barcode-vba-macro-only, function qr_gen() in barcody.bas)
… Am 18.12.2017 um 23:14 schrieb makulais ***@***.***>:
If a number with no characters included in it is input as the string to be encoded, the QR gen file does not encode any value at all into the QR code. Tested with values of 0 - 65535, ... no value is encoded into the QR code. Tested with all ECL's, no value is encoded into the QR code. If a single character is included into the string, then the QR code will correctly implement the string, but if it is strictly numbers it will not.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
JonasHeidelberg
added a commit
to JonasHeidelberg/barcode-vba-macro-only
that referenced
this issue
Dec 22, 2017
This fix addresses alitrack#4 Essentially, the original code failed to output ANY trailing numbers (probably an IF clause is missing in qr_gen() ). Previous commit fixed this for trailing multi-digit numbers, but not for single digits due to an off-by-one error. NOTE: Excel file is not updated yet! Only the barcody.bas file has been fixed. (somehow github doesn't accept file uploads right now)
|
Hi, actually my fork had already fixed this bug for inputs from 10-65535 three weeks ago. I now also fixed it for single-digit numbers - you can find the updated code here: https://github.com/JonasHeidelberg/barcode-vba-macro-only/commits/quickfix-witwall-issue-4/barcody.bas |
JonasHeidelberg
added a commit
to JonasHeidelberg/barcode-vba-macro-only
that referenced
this issue
Dec 22, 2017
* Fix an off-by-one error in barcody.bas This fix addresses alitrack#4 Essentially, the original code failed to output ANY trailing numbers (probably an IF clause is missing in qr_gen() ). Previous commit fixed this for trailing multi-digit numbers, but not for single digits due to an off-by-one error.
|
... I now also updated the XLSX and merged into my Master https://github.com/JonasHeidelberg/barcode-vba-macro-only |
JonasHeidelberg
added a commit
to JonasHeidelberg/barcode-vba-macro-only
that referenced
this issue
Dec 22, 2017
* Fix an off-by-one error in barcody.bas This fix addresses alitrack#4 Essentially, the original code failed to output ANY trailing numbers (probably an IF clause is missing in qr_gen() ). Previous commit fixed this for trailing multi-digit numbers, but not for single digits due to an off-by-one error.
|
Worked great, I thought it might be an off-by-one, but it would have taken
me forever to find it. Would love an explanation of how his code is
working! Thank you. My company decided to go ahead and purchase a dll for
use as we were concerned about bugs showing up during production, but I'll
keep this as a back up in case we ever lose that driver due to upgrades,
issues, ....
Thanks again, nice job.
Kennard
…On Fri, Dec 22, 2017 at 4:16 PM, JonasHeidelberg ***@***.***> wrote:
... I now also updated the XLSX and merged into my Master
https://github.com/JonasHeidelberg/barcode-vba-macro-only
Would love to hear if this solves your issue!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#4 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AhDk3RlhdfBrQDkcrp0EjS6aYfhiZp05ks5tDCpZgaJpZM4RGJhq>
.
|
|
Glad to hear you liked it! For commercial production code I completely agree with your company‘s decision! Until someone has made a somewhat extensive code review, this thing is a nice-to-have where you should always check that the output is what you expect...
… Am 26.12.2017 um 16:59 schrieb makulais ***@***.***>:
Worked great, I thought it might be an off-by-one, but it would have taken
me forever to find it. Would love an explanation of how his code is
working! Thank you. My company decided to go ahead and purchase a dll for
use as we were concerned about bugs showing up during production, but I'll
keep this as a back up in case we ever lose that driver due to upgrades,
issues, ....
Thanks again, nice job.
Kennard
On Fri, Dec 22, 2017 at 4:16 PM, JonasHeidelberg ***@***.***>
wrote:
> ... I now also updated the XLSX and merged into my Master
> https://github.com/JonasHeidelberg/barcode-vba-macro-only
> Would love to hear if this solves your issue!
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <#4 (comment)>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AhDk3RlhdfBrQDkcrp0EjS6aYfhiZp05ks5tDCpZgaJpZM4RGJhq>
> .
>
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
QR gen Example: In excel |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
If a number with no characters included in it is input as the string to be encoded, the QR gen file does not encode any value at all into the QR code. Tested with values of 0 - 65535, ... no value is encoded into the QR code. Tested with all ECL's, no value is encoded into the QR code. If a single character is included into the string, then the QR code will correctly implement the string, but if it is strictly numbers it will not.
The text was updated successfully, but these errors were encountered: