Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to use redis instead of coredis #210

Open
hxyannay opened this issue Apr 14, 2024 · 2 comments
Open

Move to use redis instead of coredis #210

hxyannay opened this issue Apr 14, 2024 · 2 comments

Comments

@hxyannay
Copy link

Hey.
I was reading the docs and saw that the library uses coredis for the async usage of redis.
I assume that this is due to lacking support for asyncio in redis when it was developed.

However, the official library for redis is much more maintained and is the more logical library to use, and by now it has full support for asyncio.

Are you open to the idea of moving to use the official library instead of coredis? If so I can try to open a PR myself for that.

Thanks!

@alisaifee
Copy link
Owner

I'm open to the idea if it can be done in a backward compatible way

@tuukkamustonen
Copy link

Would it be "just" re-writing https://github.com/alisaifee/limits/blob/master/limits/aio/storage/redis.py using redis? Do you foresee some issues there, @alisaifee?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants