-
-
Notifications
You must be signed in to change notification settings - Fork 60
Add gentoo #2006
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add gentoo #2006
Conversation
* dev: check templates are up to date * Touch template * Better feedback * Restore touched template
* dev: instructions for copilot reviews * Add info about testing
…2000) * Minimal spec for future property * Implementation & Test * Do not leak hidden property
…ject#2003) * attempt fixing workflow on aarch64 linux * dev: force macOS 14 macos-latest runner is now macOS 15 which breaks things, yet to diagnose... * fix: force macOS 14 in `ci-toolchain.yml` * dev: remove custom aarch case from `ci-release.yml` * Revert "dev: remove custom aarch case from `ci-release.yml`" This reverts commit 069997e. --------- Co-authored-by: Alejandro R Mosteo <[email protected]>
…ject#2005) * Add test * Fix incidental output breaking structured output * Add note to `--format`'s description * Fix typo in test comment Co-authored-by: Copilot <[email protected]> --------- Co-authored-by: Copilot <[email protected]>
|
Absolutely no idea why this fails on gcc 10. I don't have it installed here as it's now masked and cannot be installed easily. This is the line: return (if Line (Line'First .. Line'First + Indicator'Length) = Indicator
then True else False);Would changing it to: return Line (Line'First .. Line'First + Indicator'Length) = Indicator;Instead work? |
|
Any ideas? |
|
I believe the issue is that Ada ranges are inclusive (not half-open intervals like many other languages), so you probably want something like return Line (Line'First .. Line'First + Indicator'Length - 1) = Indicator;I'm a little surprised that only GCC 10 catches this, though, so perhaps I'm missing something. I'm not familiar with the That said, it would likely be easier to just use the |
Check to make sure we have a line to check before checking the line.
* feat: minimal vetting of GH PATs * Old check when forcing
|
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days. |
Nothing I can do. |
You can go over the review comments and fix those, that will remove the Stale status (and make the PR ready to merge :-)) |
I've no idea what you're talking about here. I can't review it, it's not my project. |
| function Install (This : Deployer) return Outcome; | ||
|
|
||
| overriding | ||
| function Executable_Name (This : Deployer) return String is ("apt"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this apt correct?
| Indicator : constant String := "[I]"; | ||
| Line : constant String := AAA.Strings.First_Element (Output); | ||
| begin | ||
| Trace.Info ("Already_Installed: " & This.Base.Package_Name); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Logging at info level in a deployer will be noisy/confusing, I suggest downgrading at least to detail.
| return False; | ||
| end Already_Installed; | ||
|
|
||
| function To_Semantic_Version (Gentoo_Version : String) return String is |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing subprogram box here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you mean "box?"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A comment with the name of the function inside a "box":
-------------------------
-- To_Semantic_Version --
-------------------------
GNAT Studio has a command to automate this process. Look in the shortcut settings.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm in vscode.
| if Tmp (C) = L1.Low_Line then | ||
| Tmp (C) := L1.Hyphen; | ||
|
|
||
| Trace.Info ("To_Semantic_Version: " & Tmp); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like debug output
| end if; | ||
| end loop; | ||
|
|
||
| Trace.Info ("To_Semantic_Version: " & Tmp); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like debug output
I did the review, my fault, I had left in draft. |
|
No idea why this is failing. I don't know if it's me or not. |
As identified in this CI check, 60705e7 reverted the |
I think I merged an update rather than rebased. |
Adds in support for Gentoo's Portage.
PR creation checklist
doc/user-changes.mdhas been updated, if there are user-visible changes.doc/catalog-format-spec.mdhas been updated, if applicable.BREAKING.mdhas been updated for major changes inalr, minor/major in catalog format.