Skip to content

Conversation

@Lucretia
Copy link

Adds in support for Gentoo's Portage.

PR creation checklist
  • A test is included, if required by the changes.
  • doc/user-changes.md has been updated, if there are user-visible changes.
  • doc/catalog-format-spec.md has been updated, if applicable.
  • BREAKING.md has been updated for major changes in alr, minor/major in catalog format.

Lucretia and others added 12 commits July 31, 2025 20:32
* dev: check templates are up to date

* Touch template

* Better feedback

* Restore touched template
* dev: instructions for copilot reviews

* Add info about testing
…2000)

* Minimal spec for future property

* Implementation & Test

* Do not leak hidden property
…ject#2003)

* attempt fixing workflow on aarch64 linux

* dev: force macOS 14

macos-latest runner is now macOS 15 which breaks things, yet to diagnose...

* fix: force macOS 14 in `ci-toolchain.yml`

* dev: remove custom aarch case from `ci-release.yml`

* Revert "dev: remove custom aarch case from `ci-release.yml`"

This reverts commit 069997e.

---------

Co-authored-by: Alejandro R Mosteo <[email protected]>
…ject#2005)

* Add test

* Fix incidental output breaking structured output

* Add note to `--format`'s description

* Fix typo in test comment

Co-authored-by: Copilot <[email protected]>

---------

Co-authored-by: Copilot <[email protected]>
@Lucretia
Copy link
Author

Lucretia commented Sep 13, 2025

Absolutely no idea why this fails on gcc 10. I don't have it installed here as it's now masked and cannot be installed easily. This is the line:

      return (if Line (Line'First .. Line'First + Indicator'Length) = Indicator
              then True else False);

Would changing it to:

return Line (Line'First .. Line'First + Indicator'Length) = Indicator;

Instead work?

@Lucretia
Copy link
Author

Any ideas?

@Seb-MCaw
Copy link
Contributor

Seb-MCaw commented Sep 14, 2025

I believe the issue is that Ada ranges are inclusive (not half-open intervals like many other languages), so you probably want something like

return Line (Line'First .. Line'First + Indicator'Length - 1) = Indicator;

I'm a little surprised that only GCC 10 catches this, though, so perhaps I'm missing something.

I'm not familiar with the eix command, but it would probably also be a good idea to check that Line'Length >= Indicator'Length to avoid a Constraint_Error.

That said, it would likely be easier to just use the Has_Prefix function already provided by AAA.Strings.

Lucretia and others added 3 commits September 27, 2025 20:16
Check to make sure we have a line to check before checking the line.
* feat: minimal vetting of GH PATs

* Old check when forcing
@github-actions
Copy link

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days.

@github-actions github-actions bot added the Stale label Nov 27, 2025
@Lucretia
Copy link
Author

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days.

Nothing I can do.

@mosteo
Copy link
Member

mosteo commented Nov 27, 2025

Nothing I can do.

You can go over the review comments and fix those, that will remove the Stale status (and make the PR ready to merge :-))

@Lucretia
Copy link
Author

Nothing I can do.

You can go over the review comments and fix those, that will remove the Stale status (and make the PR ready to merge :-))

I've no idea what you're talking about here. I can't review it, it's not my project.

function Install (This : Deployer) return Outcome;

overriding
function Executable_Name (This : Deployer) return String is ("apt");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this apt correct?

Indicator : constant String := "[I]";
Line : constant String := AAA.Strings.First_Element (Output);
begin
Trace.Info ("Already_Installed: " & This.Base.Package_Name);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logging at info level in a deployer will be noisy/confusing, I suggest downgrading at least to detail.

return False;
end Already_Installed;

function To_Semantic_Version (Gentoo_Version : String) return String is
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing subprogram box here

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you mean "box?"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A comment with the name of the function inside a "box":

   -------------------------
   -- To_Semantic_Version --
   -------------------------

GNAT Studio has a command to automate this process. Look in the shortcut settings.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm in vscode.

if Tmp (C) = L1.Low_Line then
Tmp (C) := L1.Hyphen;

Trace.Info ("To_Semantic_Version: " & Tmp);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like debug output

end if;
end loop;

Trace.Info ("To_Semantic_Version: " & Tmp);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like debug output

@mosteo
Copy link
Member

mosteo commented Nov 27, 2025

I've no idea what you're talking about here. I can't review it, it's not my project.

I did the review, my fault, I had left in draft.

@github-actions github-actions bot removed the Stale label Nov 28, 2025
@Lucretia
Copy link
Author

No idea why this is failing. I don't know if it's me or not.

@Seb-MCaw
Copy link
Contributor

Seb-MCaw commented Dec 1, 2025

No idea why this is failing. I don't know if it's me or not.

As identified in this CI check, 60705e7 reverted the deps/den submodule from bab6ef5 to 7732f92; presumably something got confused after the merge from master?

@Lucretia
Copy link
Author

Lucretia commented Dec 1, 2025

No idea why this is failing. I don't know if it's me or not.

As identified in this CI check, 60705e7 reverted the deps/den submodule from bab6ef5 to 7732f92; presumably something got confused after the merge from master?

I think I merged an update rather than rebased.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants