Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update of package & maintenance #15

Closed
wants to merge 0 commits into from
Closed

Conversation

RUrlus
Copy link

@RUrlus RUrlus commented Mar 21, 2022

Hi @alimuldal,

Thank you for the package. I came across the repo and given the no-maintenance intended note updated it.
Would you be willing to accept the PR with the idea that I'll take over maintenance? If not, I'll create a stand-alone repo from the fork but it might be nice to keep the name.

The PR contains the following changes and enhancements:

Changes

  • Revert to original 1 base indexing for dip.c as I encountered buffer overruns with the 0 based indexing
  • Switch to C++ bindings using Pybind11

Enhancements

  • Moved p-value computation using bootstrapping to C++
  • Added optional parallelisation (OpenMP) for p-value computation
  • Move debug checks under compile-time definition
  • CICD pipeline to create wheels across Windows, Linux and MacOS
  • Valgrind and Asan tests in the pipelines

fixes #5, fixes #7 fixes #10, fixes #11, fixes #12

@RUrlus RUrlus changed the title Update of package Update of package & maintenance Apr 14, 2022
@RUrlus RUrlus force-pushed the stable branch 4 times, most recently from 98879cd to 2c69f48 Compare May 6, 2022 14:06
@RUrlus
Copy link
Author

RUrlus commented Jun 27, 2022

Hi @alimuldal, would you be willing to hand-over maintenance of the repo or perhaps archive it such that we can promote the fork and keep the name?

@RUrlus RUrlus force-pushed the stable branch 2 times, most recently from 46efe8b to 6381346 Compare June 27, 2022 14:16
@RUrlus RUrlus closed this Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant