ci: remove python and add swift #292
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joe-p
force-pushed
the
ci/rm_py_add_swift
branch
2 times, most recently
from
204321e to
33ec247
Compare
joe-p
force-pushed
the
ci/rm_py_add_swift
branch
from
fff4240 to
0efede3
Compare
joe-p
requested review from
aorumbayev and
Copilot
and removed request for
a team and
aorumbayev
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the Swift package implementation to align with API changes in the underlying FFI layer. The changes primarily involve renaming function parameters and updating type handling for addresses in the Swift bindings.
- Updated FFI function signatures to use more descriptive parameter names (e.g.,
tx→transaction,bytes→encoded_tx) - Changed address handling in test utilities from complex
Addressobjects to simpleStringtypes - Enhanced FFI header files with additional function definitions for multisignature support and transaction operations
Reviewed Changes
Copilot reviewed 14 out of 24 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| TestUtils.swift | Simplified address types from Address objects to String in test data structures |
| PaymentTests.swift | Updated function calls to use new parameter names and refactored transaction signing |
| GenericTransactionTests.swift | Updated error handling to catch InputError instead of DecodingError for empty byte arrays |
| module.modulemap (multiple) | Added Darwin and builtin module dependencies |
| algokit_transactFFI.h (multiple) | Updated FFI function signatures with renamed parameters and added new multisignature functions |
| Info.plist | Reordered platform configurations for iOS simulator and device |
| swift_ci.yml | Restructured workflow to accept input parameters and removed bun-related setup |
| ci_cd.yml | Modified to call Swift CI workflow with dynamic crate/package mapping |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #286
Closes #287