Handle limit zero case in tests - the generated code should not have been manually modified. (#859)

Author: gmalouf

src/main/java/com/algorand/algosdk/v2/client/indexer/SearchForApplicationBoxes.java

@@ -30,11 +30,7 @@ public SearchForApplicationBoxes(Client client, Long applicationId) {
      * limit is not reached.
      */
     public SearchForApplicationBoxes limit(Long limit) {
-        // Only add limit parameter if limit is not null and not 0
-        // This matches behavior of other SDKs (Python/Go) which omit the parameter when limit=0
-        if (limit != null && limit != 0) {
-            addQuery("limit", String.valueOf(limit));
-        }
+        addQuery("limit", String.valueOf(limit));
         return this;
     }
 

src/test/java/com/algorand/algosdk/integration/Applications.java

@@ -386,9 +386,14 @@ public void checkAppBoxesNum(String fromClient, Long limit, int expected_num) th
         Response<BoxesResponse> r;
         if (fromClient.equals("algod"))
             r = base.aclv2.GetApplicationBoxes(this.appId).max(limit).execute();
-        else if (fromClient.equals("indexer"))
-            r = base.v2IndexerClient.searchForApplicationBoxes(this.appId).limit(limit).execute();
-        else
+        else if (fromClient.equals("indexer")) {
+            // Handle limit=0 case for indexer: omit the limit parameter to use server default
+            if (limit == 0) {
+                r = base.v2IndexerClient.searchForApplicationBoxes(this.appId).execute();
+            } else {
+                r = base.v2IndexerClient.searchForApplicationBoxes(this.appId).limit(limit).execute();
+            }
+        } else
             throw new IllegalArgumentException("expecting algod or indexer, got " + fromClient);
 
         Assert.assertTrue(r.isSuccessful());
@@ -398,7 +403,13 @@ else if (fromClient.equals("indexer"))
 
     @Then("according to indexer, with {long} being the parameter that limits results, and {string} being the parameter that sets the next result, the current application should have the following boxes {string}.")
     public void indexerCheckAppBoxesWithParams(Long limit, String next, String encodedBoxesRaw) throws Exception {
-        Response<BoxesResponse> r = base.v2IndexerClient.searchForApplicationBoxes(this.appId).limit(limit).next(next).execute();
+        // Handle limit=0 case for indexer: omit the limit parameter to use server default
+        Response<BoxesResponse> r;
+        if (limit == 0) {
+            r = base.v2IndexerClient.searchForApplicationBoxes(this.appId).next(next).execute();
+        } else {
+            r = base.v2IndexerClient.searchForApplicationBoxes(this.appId).limit(limit).next(next).execute();
+        }
         final Set<byte[]> expectedNames = new HashSet<>();
         if (!encodedBoxesRaw.isEmpty()) {
             for (String s : encodedBoxesRaw.split(":")) {

src/test/java/com/algorand/algosdk/unit/utils/TestingUtils.java

@@ -311,6 +311,6 @@ public static boolean notEmpty(String str) {
     }
 
     public static boolean notEmpty(Long val) {
-        return val != null && val != 0;
+        return val != 0;
     }
 }