Validate that both createElement *and* render are given

[Haroenv]

Description

if you only pass createElement, you mix between preact and react (or whatever else), you get an odd error

possible solutions:

• make render no longer required (return an element if renderer is passed, render in user land)? (breaking change, longer term)
• error when render is not given when renderer is given

Reproduction

#750

Steps

1. pass only renderer
2. see a funny error when something errors

Expected behavior

A clear error when render is forgotten

Environment

• OS: [e.g. Windows / Linux / macOS / iOS / Android]
• Browser: [e.g. Chrome, Safari]
• Autocomplete version: 1.4.0

[francoischalifour]

Not sure this is a great solution because you often times just need to override the Autocomplete render function without changing the renderer. For example, when you want to update the panel UI but keep using Preact.

An alternative could be to pass your framework's render function to the renderer option (on top of createElement and Fragment) and to use this render reference in the Autocomplete render function.

[Haroenv]

yes, that seems like a good idea. What I meant wasn't that it should error when only render is given though. I meant that when you give renderer without render it should error

[sarahdayan]

Related 🙂

Since we're gonna discuss templating soon, I think we should touch on this topic in the RFC.

[sarahdayan]

This is covered since 1.6.0.