fix clippy lints

Author: algesten

src/cert.rs

@@ -49,7 +49,7 @@ pub(crate) fn create_csr(pkey: &PKey<pkey::Private>, domains: &[&str]) -> Result
     let mut req_bld = X509ReqBuilder::new().expect("X509ReqBuilder");
 
     // set private/public key in builder
-    req_bld.set_pubkey(&pkey).expect("set_pubkey");
+    req_bld.set_pubkey(pkey).expect("set_pubkey");
 
     // set all domains as alt names
     let mut stack = Stack::new().expect("Stack::new");

src/dir.rs

@@ -47,7 +47,7 @@ impl<P: Persist> Directory<P> {
     /// Create a directory over a persistence implementation and directory url.
     pub fn from_url(persist: P, url: DirectoryUrl) -> Result<Directory<P>> {
         let dir_url = url.to_url();
-        let res = req_handle_error(req_get(&dir_url))?;
+        let res = req_handle_error(req_get(dir_url))?;
         let api_directory: ApiDirectory = read_json(res)?;
         let nonce_pool = Arc::new(NoncePool::new(&api_directory.newNonce));
         Ok(Directory {

src/order/auth.rs

@@ -239,7 +239,7 @@ impl<P: Persist, A> Challenge<P, A> {
                 .challenges
                 .iter()
                 .filter_map(|c| c.error.as_ref())
-                .nth(0);
+                .next();
             let reason = if let Some(error) = error {
                 format!(
                     "Failed: {}",

src/persist.rs

@@ -145,7 +145,7 @@ impl Persist for FilePersist {
 
     #[cfg(unix)]
     fn put(&self, key: &PersistKey, value: &[u8]) -> Result<()> {
-        let f_name = file_name_of(&self.dir, &key);
+        let f_name = file_name_of(&self.dir, key);
         match key.kind {
             PersistKind::AccountPrivateKey | PersistKind::PrivateKey =>
                 fs::OpenOptions::new()
@@ -161,7 +161,7 @@ impl Persist for FilePersist {
     }
 
     fn get(&self, key: &PersistKey) -> Result<Option<Vec<u8>>> {
-        let f_name = file_name_of(&self.dir, &key);
+        let f_name = file_name_of(&self.dir, key);
         let ret = if let Ok(mut file) = fs::File::open(f_name) {
             let mut v = vec![];
             file.read_to_end(&mut v)?;
@@ -173,7 +173,7 @@ impl Persist for FilePersist {
     }
 }
 
-fn file_name_of(dir: &PathBuf, key: &PersistKey) -> PathBuf {
+fn file_name_of(dir: &Path, key: &PersistKey) -> PathBuf {
     let mut f_name = dir.join(key.to_string());
     f_name.set_extension(key.kind.name());
     f_name