Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't respect "exclude" configuration #20

Open
sloria opened this issue Jan 17, 2015 · 4 comments
Open

Doesn't respect "exclude" configuration #20

sloria opened this issue Jan 17, 2015 · 4 comments

Comments

@sloria
Copy link

sloria commented Jan 17, 2015

I have configuration in a setup.cfg file with the ignore, max-line-length, and exclude options set. ignore and max-line-length work as expected, but exclude is not working; khuno will still flake files that are in the exclude list.

http://flake8.readthedocs.org/en/2.2.3/config.html#settings

@alfredodeza
Copy link
Owner

This is odd, because although you are right in that Khuno will still flake the files in exclude it also does it directly with flake8 in the command line.

Are you able to flake8 behave correctly and not khuno?

@alfredodeza
Copy link
Owner

I was also able to call flake8 directly on an excluded path (which is what khuno does in the end) and I was able to see the file linted.

@alfredodeza
Copy link
Owner

I managed to get a better understanding why this is happening, and opened an issue on flake8 tracker:
https://gitlab.com/pycqa/flake8/issues/29

@alfredodeza
Copy link
Owner

@sloria it seems that the flake8 issue was closed because this is expected behavior (as they explain it on their tracker, see https://gitlab.com/pycqa/flake8/issues/29).

I'm trying to point out that this should at least be documented and if possible a flag for strict behavior should be in effect so that we don't have this problem.

If you feel this is right, I would encourage you to add a comment on their tracker pointing this out.

In the meantime I will try and get a workaround.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants