Rubocop

Author: alexrudall

lib/openai.rb

@@ -21,16 +21,14 @@ class ConfigurationError < Error; end
 
   class MiddlewareErrors < Faraday::Middleware
     def call(env)
-      begin
-        @app.call(env)
-      rescue Faraday::Error => e
-        raise e unless e.response.is_a?(Hash)
+      @app.call(env)
+    rescue Faraday::Error => e
+      raise e unless e.response.is_a?(Hash)
 
-        logger = Logger.new(STDOUT)
-        logger.error(e.response[:body])
+      logger = Logger.new($stdout)
+      logger.error(e.response[:body])
 
-        raise e
-      end
+      raise e
     end
   end
 

spec/openai/client/chat_spec.rb

@@ -32,7 +32,14 @@
               }
             ]
           end
-          let(:parameters) { { model: model, messages: messages, stream: stream, functions: functions } }
+          let(:parameters) do
+            {
+              model: model,
+              messages: messages,
+              stream: stream,
+              functions: functions
+            }
+          end
           let(:functions) do
             [
               {

spec/openai/client/run_steps_spec.rb

@@ -37,7 +37,7 @@
 
       it "succeeds" do
         VCR.use_cassette(cassette) do
-          expect(response.dig("object")).to eq("list")
+          expect(response["object"]).to eq("list")
         end
       end
     end
@@ -54,11 +54,9 @@
 
       it "returns the correct error" do
         VCR.use_cassette(cassette) do
-          begin
-            response
-          rescue => e
-            expect(e.response.dig(:body, 'error', 'message')).to include("No run step found")
-          end
+          response
+        rescue StandardError => e
+          expect(e.response.dig(:body, "error", "message")).to include("No run step found")
         end
       end
     end