Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve validation around params changing #94

Open
3 tasks
alexlafroscia opened this issue Apr 2, 2018 · 3 comments
Open
3 tasks

Improve validation around params changing #94

alexlafroscia opened this issue Apr 2, 2018 · 3 comments

Comments

@alexlafroscia
Copy link
Owner

alexlafroscia commented Apr 2, 2018

  • Figure out how to actually write tests for errors being thrown
  • Un-skip skipped tests
  • Make sure that the following attributes all throw an error when changed
    • step
      • name
    • step-manager
      • initialStep
      • linear
@alexlafroscia
Copy link
Owner Author

Related issue: workmanw/ember-qunit-assert-helpers#18

@alexlafroscia
Copy link
Owner Author

On second though, maybe it should just be an Ember.warn rather than an Ember.assert. In reality, it's not that bad if initialStep or linear change, it should just be made really clear that changing those values after the initial render will not do anything.

step.name is a little more complex. In reality, the state machine could support updating names of steps, but it's probably not that useful. However, I'm going to support removing steps, so handling renames actually wouldn't be that hard.

@alexlafroscia
Copy link
Owner Author

Once this is resolved, it makes most sense to approach argument validation that way:

ember-decorators/argument#65

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant