dotSimilarity does not return negative floats

joancf · joancf · commit 10285720fb00 · 2024-04-05T18:35:57.000+02:00
diff --git a/elastiknn-models/src/main/java/com/klibisz/elastiknn/models/ExactModel.java b/elastiknn-models/src/main/java/com/klibisz/elastiknn/models/ExactModel.java
@@ -41,6 +41,6 @@ public static double cosineSimilarity(FloatVectorOps floatVectorOps, float[] v1,
 
     @ForceInline
     public static double dotSimilarity(FloatVectorOps floatVectorOps, float[] v1, float[] v2) {
-        return 1 + floatVectorOps.dotSimilarity(v1, v2);
+        return Math.max(-1.0,1 + floatVectorOps.dotSimilarity(v1, v2));
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -41,6 +41,6 @@ public static double cosineSimilarity(FloatVectorOps floatVectorOps, float[] v1,`
`41`	`41`
`42`	`42`	`@ForceInline`
`43`	`43`	`public static double dotSimilarity(FloatVectorOps floatVectorOps, float[] v1, float[] v2) {`
`44`		`- return 1 + floatVectorOps.dotSimilarity(v1, v2);`
	`44`	`+ return Math.max(-1.0,1 + floatVectorOps.dotSimilarity(v1, v2));`
`45`	`45`	`}`
`46`	`46`	`}`