Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make tests pass specification #1

Open
alexkappa opened this issue Dec 7, 2014 · 1 comment
Open

Make tests pass specification #1

alexkappa opened this issue Dec 7, 2014 · 1 comment
Labels
help wanted

Comments

@alexkappa
Copy link
Owner

In order to release this package with a degree of confidence, I would like to make sure that a significant amount (if not all) of specification tests can pass.

Currently most tests fail simply due to the fact that the output contains more newlines as the expectation. The spec states that if a line of text only contains whitespace and a mustache tag such as a comment or a section, this line should be omitted from the output.
@alexkappa
Copy link
Owner Author

I suspect the easiest way to be aware of lines with only a standalone tag, is to improve the lexer to emit new lines as separate tokens and during rendering we could look back and see if the previous nodes until the last line had nodes that affected the output.

E.g. [textToken "\n", sectionToken "foo", textToken "\n"] should not render anything while [textToken "\n", sectionToken "foo", textToken "some text here", textToken "\n"] should render both text and new lines.

xueweiz pushed a commit to xueweiz/mustache that referenced this issue Apr 5, 2021
Allow non-alphanum characters in tag content
5931769 
The tag context should allow non-alphanum characters. See the spec for
section tag content [1]:

> These tags' content MUST be a non-whitespace character sequence NOT
> containing the current closing delimiter; ...

For the 3 added test cases, alexkappa#1 and alexkappa#3 will fail today, and alexkappa#2 will
trigger a panic. The code change fixes them.

The expected behavior can also be verified on
http://mustache.github.io/#demo, with Mustache:
1: {{#key*}}{{.}}{{/key*}}
2: {{#key}}{{*}}{{/key}}
2: {{#key}}{{*}*}}{{/key}}

and JSON:
{
  "key*": "value*",
  "key": "value",
  "*": "star",
  "*}*": "fish"
}

We can get output as:
1: value*
2: star
2: fish

[1] https://github.com/mustache/spec/blob/b1329a25e6d265ff360267d23f7c6327bbf59f52/specs/sections.yml#L5
@xueweiz xueweiz mentioned this issue Apr 5, 2021
Open
xueweiz pushed a commit to xueweiz/mustache that referenced this issue Apr 5, 2021
Allow non-alphanum characters in tag content
b7d834c 
The tag content should allow non-alphanum characters. See the spec for
section tag content [1]:

> These tags' content MUST be a non-whitespace character sequence NOT
> containing the current closing delimiter; ...

For the 3 added test cases, alexkappa#1 and alexkappa#3 will fail today, and alexkappa#2 will
trigger a panic. The code change fixes them.

The expected behavior can also be verified on
http://mustache.github.io/#demo, with Mustache:
1: {{#key*}}{{.}}{{/key*}}
2: {{#key}}{{*}}{{/key}}
2: {{#key}}{{*}*}}{{/key}}

and JSON:
{
  "key*": "value*",
  "key": "value",
  "*": "star",
  "*}*": "fish"
}

We can get output as:
1: value*
2: star
2: fish

[1] https://github.com/mustache/spec/blob/b1329a25e6d265ff360267d23f7c6327bbf59f52/specs/sections.yml#L5
xueweiz pushed a commit to xueweiz/mustache that referenced this issue Apr 8, 2021
Allow non-alphanum characters in tag content
e2c25b8 
The tag content should allow non-alphanum characters. See the spec for
section tag content [1]:

> These tags' content MUST be a non-whitespace character sequence NOT
> containing the current closing delimiter; ...

For the 3 added test cases, alexkappa#1 and alexkappa#3 will fail today, and alexkappa#2 will
trigger a panic. The code change fixes them.

The expected behavior can also be verified on
http://mustache.github.io/#demo, with Mustache:
1: {{#key*}}{{.}}{{/key*}}
2: {{#key}}{{*}}{{/key}}
2: {{#key}}{{*}*}}{{/key}}

and JSON:
{
  "key*": "value*",
  "key": "value",
  "*": "star",
  "*}*": "fish"
}

We can get output as:
1: value*
2: star
2: fish

[1] https://github.com/mustache/spec/blob/b1329a25e6d265ff360267d23f7c6327bbf59f52/specs/sections.yml#L5
xueweiz pushed a commit to xueweiz/mustache that referenced this issue Apr 8, 2021
Allow non-alphanum characters in tag content
d5fe45c 
The tag content should allow non-alphanum characters. See the spec for
section tag content [1]:

> These tags' content MUST be a non-whitespace character sequence NOT
> containing the current closing delimiter; ...

For the 3 added test cases, alexkappa#1 and alexkappa#3 will fail today, and alexkappa#2 will
trigger a panic. The code change fixes them.

The expected behavior can also be verified on
http://mustache.github.io/#demo, with Mustache:
1: {{#key*}}{{.}}{{/key*}}
2: {{#key}}{{*}}{{/key}}
2: {{#key}}{{*}*}}{{/key}}

and JSON:
{
  "key*": "value*",
  "key": "value",
  "*": "star",
  "*}*": "fish"
}

We can get output as:
1: value*
2: star
2: fish

[1] https://github.com/mustache/spec/blob/b1329a25e6d265ff360267d23f7c6327bbf59f52/specs/sections.yml#L5
xueweiz pushed a commit to xueweiz/mustache that referenced this issue Apr 9, 2021
@xueweiz
Allow non-alphanum characters in tag content
567ca09 
The tag content should allow non-alphanum characters. See the spec for
section tag content [1]:

> These tags' content MUST be a non-whitespace character sequence NOT
> containing the current closing delimiter; ...

For the 3 added test cases, alexkappa#1 and alexkappa#3 will fail today, and alexkappa#2 will
trigger a panic. The code change fixes them.

The expected behavior can also be verified on
http://mustache.github.io/#demo, with Mustache:
1: {{#key*}}{{.}}{{/key*}}
2: {{#key}}{{*}}{{/key}}
2: {{#key}}{{*}*}}{{/key}}

and JSON:
{
  "key*": "value*",
  "key": "value",
  "*": "star",
  "*}*": "fish"
}

We can get output as:
1: value*
2: star
2: fish

[1] https://github.com/mustache/spec/blob/b1329a25e6d265ff360267d23f7c6327bbf59f52/specs/sections.yml#L5
xueweiz pushed a commit to xueweiz/mustache that referenced this issue Apr 9, 2021
Allow non-alphanum characters in tag content
e31dfb8 
The tag content should allow non-alphanum characters. See the spec for
section tag content [1]:

> These tags' content MUST be a non-whitespace character sequence NOT
> containing the current closing delimiter; ...

For the 3 added test cases, alexkappa#1 and alexkappa#3 will fail today, and alexkappa#2 will
trigger a panic. The code change fixes them.

The expected behavior can also be verified on
http://mustache.github.io/#demo, with Mustache:
1: {{#key*}}{{.}}{{/key*}}
2: {{#key}}{{*}}{{/key}}
2: {{#key}}{{*}*}}{{/key}}

and JSON:
{
  "key*": "value*",
  "key": "value",
  "*": "star",
  "*}*": "fish"
}

We can get output as:
1: value*
2: star
2: fish

[1] https://github.com/mustache/spec/blob/b1329a25e6d265ff360267d23f7c6327bbf59f52/specs/sections.yml#L5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@alexkappa