Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Oq calculation: Apply different methods for distinct portions? #8

Open
MinhChauNGUYEN opened this issue May 22, 2019 · 1 comment
Open

Comments

@MinhChauNGUYEN
Copy link
Collaborator

For the verification of f0, we can setting different thresholds for several distinct portions.
Regarding Oq calculation, the opening peaks can be also very diverse in one token.
Is that possible if PeakDet has a setting to change the method for a particular portion? And should we do it?

@alexis-michaud
Copy link
Owner

On principle, yes, it would make sense to detect some of the cycles by means of the pulses in the second derivative, and others by means of a barycentre method applied to the local minima in the first derivative, for instance. Some of this could be automatic or semi-automatic: first, determining for a given token which method yields best results (consistent & clear), then trying to crack the tough nuts: do a diagnosis on the more difficult cycles, to see whether O_q is simply not a relevant measurement for these cycles, or whether a different method gives a clear & convincing result.

This will take serious programming, though. For the sake of your PhD, I'd recommend making do with the current setup, and using just one method for one token. A workaround consists in making manual changes: this gives full freedom to the user to 'pick and choose' from various methods. This complete freedom also allows the user to make big mistakes and to do some unprincipled 'cherry-picking', so it's to be used very carefully, of course.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants