Fix gh CLI for Darwin

The upstream project renamed the .tar.gz file to .zip for MacOS/Darwin Signed-off-by: Alex Ellis (OpenFaaS Ltd) <[email protected]>
alexellis · Sep 13, 2023 · b3e4aa0 · b3e4aa0
1 parent d6eff90
commit b3e4aa0
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/pkg/get/get_test.go b/pkg/get/get_test.go
@@ -1439,7 +1439,12 @@ func Test_DownloadGH(t *testing.T) {
 		{os: "darwin",
 			arch:    arch64bit,
 			version: toolVersion,
-			url:     `https://github.com/cli/cli/releases/download/v1.6.1/gh_1.6.1_macOS_amd64.tar.gz`,
+			url:     `https://github.com/cli/cli/releases/download/v1.6.1/gh_1.6.1_macOS_amd64.zip`,
+		},
+		{os: "darwin",
+			arch:    archARM64,
+			version: toolVersion,
+			url:     `https://github.com/cli/cli/releases/download/v1.6.1/gh_1.6.1_macOS_arm64.zip`,
 		},
 		{os: "linux",
 			arch:    archARM64,

diff --git a/pkg/get/tools.go b/pkg/get/tools.go
@@ -930,6 +930,8 @@ https://releases.hashicorp.com/{{.Name}}/{{.Version}}/{{.Name}}_{{.Version}}_{{$
 	{{$extStr := "tar.gz"}}
 	{{ if HasPrefix .OS "ming" -}}
 	{{$extStr = "zip"}}
+	{{- else if eq .OS "darwin" -}}
+	{{$extStr = "zip"}}
 	{{- end -}}
 
 	{{$osStr := ""}}