Skip to content

Commit 34ca06f

Browse files
committed
Update tool defintion for viddy
Breaking changes detected via e2e tests and fixed Signed-off-by: Alex Ellis (OpenFaaS Ltd) <[email protected]>
1 parent 568ded2 commit 34ca06f

File tree

2 files changed

+9
-11
lines changed

2 files changed

+9
-11
lines changed

pkg/get/get_test.go

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -5629,31 +5629,31 @@ func Test_DownloadViddy(t *testing.T) {
56295629
os: "darwin",
56305630
arch: arch64bit,
56315631
version: version,
5632-
url: "https://github.com/sachaos/viddy/releases/download/v0.3.6/viddy_Darwin_x86_64.tar.gz",
5632+
url: "https://github.com/sachaos/viddy/releases/download/v0.3.6/viddy-v0.3.6-macos-x86_64.tar.gz",
56335633
},
56345634
{
56355635
os: "darwin",
56365636
arch: archDarwinARM64,
56375637
version: version,
5638-
url: "https://github.com/sachaos/viddy/releases/download/v0.3.6/viddy_Darwin_arm64.tar.gz",
5638+
url: "https://github.com/sachaos/viddy/releases/download/v0.3.6/viddy-v0.3.6-macos-arm64.tar.gz",
56395639
},
56405640
{
56415641
os: "linux",
56425642
arch: arch64bit,
56435643
version: version,
5644-
url: "https://github.com/sachaos/viddy/releases/download/v0.3.6/viddy_Linux_x86_64.tar.gz",
5644+
url: "https://github.com/sachaos/viddy/releases/download/v0.3.6/viddy-v0.3.6-linux-x86_64.tar.gz",
56455645
},
56465646
{
56475647
os: "linux",
56485648
arch: archARM64,
56495649
version: version,
5650-
url: "https://github.com/sachaos/viddy/releases/download/v0.3.6/viddy_Linux_arm64.tar.gz",
5650+
url: "https://github.com/sachaos/viddy/releases/download/v0.3.6/viddy-v0.3.6-linux-arm64.tar.gz",
56515651
},
56525652
{
56535653
os: "ming",
56545654
arch: arch64bit,
56555655
version: version,
5656-
url: "https://github.com/sachaos/viddy/releases/download/v0.3.6/viddy_Windows_x86_64.tar.gz",
5656+
url: "https://github.com/sachaos/viddy/releases/download/v0.3.6/viddy-v0.3.6-windows-x86_64.tar.gz",
56575657
},
56585658
}
56595659

pkg/get/tools.go

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -3167,16 +3167,14 @@ https://github.com/{{.Owner}}/{{.Repo}}/releases/download/{{.Version}}/{{.Name}}
31673167
{{$arch = "arm64"}}
31683168
{{- end -}}
31693169
3170-
{{$osStr := ""}}
3170+
{{$osStr := .OS}}
31713171
{{ if HasPrefix .OS "ming" -}}
3172-
{{$osStr = "Windows"}}
3173-
{{- else if eq .OS "linux" -}}
3174-
{{$osStr = "Linux"}}
3172+
{{$osStr = "windows"}}
31753173
{{- else if eq .OS "darwin" -}}
3176-
{{$osStr = "Darwin"}}
3174+
{{$osStr = "macos"}}
31773175
{{- end -}}
31783176
3179-
{{.Name}}_{{$osStr}}_{{$arch}}.{{$ext}}
3177+
{{.Name}}-{{.Version}}-{{$osStr}}-{{$arch}}.{{$ext}}
31803178
`,
31813179
})
31823180

0 commit comments

Comments
 (0)