eslint-plugin-ember linter addon

Author: alexdiliberto

.eslintrc.js

@@ -6,7 +6,7 @@ module.exports = {
   },
   extends: [
     'eslint:recommended',
-    'plugin:ember-suave/recommended'
+    'plugin:ember/recommended'
   ],
   env: {
     browser: true

CHANGELOG.md

@@ -4,6 +4,9 @@ This project adheres to [Semantic Versioning](http://semver.org/).
 
 
 ## [Unreleased][unreleased]
+### Added
+  - `eslint-plugin-ember` linter addon 
+
 ### Updated
   - `package.json` dependencies
   - Ember CLI v2.13.2
@@ -12,6 +15,7 @@ This project adheres to [Semantic Versioning](http://semver.org/).
 
 ### Removed
   - `ember-cli-release` package
+  - `eslint-plugin-ember-suave` package
 
 
 ## [v1.0.1] - 2017-04-13

package.json

@@ -37,7 +37,8 @@
   },
   "dependencies": {
     "ember-cli-babel": "^6.4.1",
-    "ember-cli-htmlbars": "^2.0.2"
+    "ember-cli-htmlbars": "^2.0.2",
+    "eslint-plugin-ember": "^3.4.1"
   },
   "devDependencies": {
     "broccoli-asset-rev": "^2.4.5",
@@ -67,7 +68,6 @@
     "ember-percy": "1.2.12",
     "ember-resolver": "^4.0.0",
     "ember-source": "^2.13.3",
-    "eslint-plugin-ember-suave": "^1.0.0",
     "loader.js": "4.4.1",
     "mocha": "^3.4.2",
     "request": "^2.81.0",

tests/.eslintrc.js

@@ -3,6 +3,6 @@ module.exports = {
     embertest: true
   },
   rules: {
-    'ember-suave/no-direct-property-access': 'off'
+    'ember/alias-model-in-controller': 'off'
   }
 };

tests/dummy/app/app.js

@@ -3,13 +3,18 @@ import Resolver from './resolver';
 import loadInitializers from 'ember-load-initializers';
 import config from './config/environment';
 
+const {
+  LinkComponent,
+  Application
+} = Ember;
+
 let App;
 
-Ember.LinkComponent.reopen({
+LinkComponent.reopen({
   attributeBindings: ['role']
 });
 
-App = Ember.Application.extend({
+App = Application.extend({
   modulePrefix: config.modulePrefix,
   podModulePrefix: config.podModulePrefix,
   Resolver

tests/helpers/destroy-app.js

@@ -1,5 +1,9 @@
 import Ember from 'ember';
 
+const {
+  run
+} = Ember;
+
 export default function destroyApp(application) {
-  Ember.run(application, 'destroy');
+  run(application, 'destroy');
 }

tests/helpers/module-for-acceptance.js

@@ -6,6 +6,7 @@ import 'dummy/tests/helpers/percy/register-helpers';
 
 const { RSVP: { Promise } } = Ember;
 
+/* eslint-disable ember/named-functions-in-promises */
 export default function(name, options = {}) {
   module(name, {
     beforeEach() {

tests/helpers/start-app.js

@@ -2,11 +2,16 @@ import Ember from 'ember';
 import Application from '../../app';
 import config from '../../config/environment';
 
+const {
+  merge,
+  run
+} = Ember;
+
 export default function startApp(attrs) {
-  let attributes = Ember.merge({}, config.APP);
-  attributes = Ember.merge(attributes, attrs); // use defaults, but you can override;
+  let attributes = merge({}, config.APP);
+  attributes = merge(attributes, attrs); // use defaults, but you can override;
 
-  return Ember.run(() => {
+  return run(() => {
     let application = Application.create(attributes);
     application.setupForTesting();
     application.injectTestHelpers();

yarn.lock

@@ -2667,11 +2667,12 @@ escope@^3.6.0:
     esrecurse "^4.1.0"
     estraverse "^4.1.1"
 
-eslint-plugin-ember-suave@^1.0.0:
-  version "1.0.0"
-  resolved "https://registry.yarnpkg.com/eslint-plugin-ember-suave/-/eslint-plugin-ember-suave-1.0.0.tgz#ea7d232a126562dcd8b1ee3aa2700ac3b626e514"
+eslint-plugin-ember@^3.4.1:
+  version "3.4.1"
+  resolved "https://registry.yarnpkg.com/eslint-plugin-ember/-/eslint-plugin-ember-3.4.1.tgz#849124656bd1e0786f85425f0b50f8b0724a8115"
   dependencies:
-    requireindex "~1.1.0"
+    requireindex "^1.1.0"
+    snake-case "^2.1.0"
 
 eslint@^3.0.0:
   version "3.19.0"
@@ -4181,6 +4182,10 @@ loud-rejection@^1.0.0:
     currently-unhandled "^0.4.1"
     signal-exit "^3.0.0"
 
+lower-case@^1.1.1:
+  version "1.1.4"
+  resolved "https://registry.yarnpkg.com/lower-case/-/lower-case-1.1.4.tgz#9a2cabd1b9e8e0ae993a4bf7d5875c39c42e8eac"
+
 lru-cache@^4.0.1:
   version "4.0.2"
   resolved "https://registry.yarnpkg.com/lru-cache/-/lru-cache-4.0.2.tgz#1d17679c069cda5d040991a09dbc2c0db377e55e"
@@ -4442,6 +4447,12 @@ [email protected]:
   version "0.6.1"
   resolved "https://registry.yarnpkg.com/negotiator/-/negotiator-0.6.1.tgz#2b327184e8992101177b28563fb5e7102acd0ca9"
 
+no-case@^2.2.0:
+  version "2.3.1"
+  resolved "https://registry.yarnpkg.com/no-case/-/no-case-2.3.1.tgz#7aeba1c73a52184265554b7dc03baf720df80081"
+  dependencies:
+    lower-case "^1.1.1"
+
 node-fetch@^1.3.3:
   version "1.6.3"
   resolved "https://registry.yarnpkg.com/node-fetch/-/node-fetch-1.6.3.tgz#dc234edd6489982d58e8f0db4f695029abcd8c04"
@@ -5179,7 +5190,7 @@ require-uncached@^1.0.2:
     caller-path "^0.1.0"
     resolve-from "^1.0.0"
 
-requireindex@~1.1.0:
+requireindex@^1.1.0:
   version "1.1.0"
   resolved "https://registry.yarnpkg.com/requireindex/-/requireindex-1.1.0.tgz#e5404b81557ef75db6e49c5a72004893fe03e162"
 
@@ -5410,6 +5421,12 @@ slide@^1.1.5:
   version "1.1.6"
   resolved "https://registry.yarnpkg.com/slide/-/slide-1.1.6.tgz#56eb027d65b4d2dce6cb2e2d32c4d4afc9e1d707"
 
+snake-case@^2.1.0:
+  version "2.1.0"
+  resolved "https://registry.yarnpkg.com/snake-case/-/snake-case-2.1.0.tgz#41bdb1b73f30ec66a04d4e2cad1b76387d4d6d9f"
+  dependencies:
+    no-case "^2.2.0"
+
 [email protected]:
   version "1.0.9"
   resolved "https://registry.yarnpkg.com/sntp/-/sntp-1.0.9.tgz#6541184cc90aeea6c6e7b35e2659082443c66198"