Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alt & title arguments of the media viewhelper are not respected #34

Open
tilman82 opened this issue May 2, 2018 · 0 comments
Open

Alt & title arguments of the media viewhelper are not respected #34

tilman82 opened this issue May 2, 2018 · 0 comments

Comments

@tilman82
Copy link

tilman82 commented May 2, 2018

Hi,

it seems that the alt and the title arguments of the media viewhelper are totally ignored in the rendered image tags. We use the extension in a multilanguage project, here the title and alt of the root language is used, no matter what's written in the viewhelper.

I think of two possible solutions:

  • Add title and alt to the $genericTagAttributes in ImageRendererConfiguration,
  • or read them directly from the $options in the buildImageTag function...

In both cases it's not needed anymore to get the properties from the FileInterface...

What do you think?

Bregs
Tilman

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant