Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Utterance generation bug #16

Closed
mseminatore opened this issue Jan 11, 2017 · 2 comments
Closed

Utterance generation bug #16

mseminatore opened this issue Jan 11, 2017 · 2 comments

Comments

@mseminatore
Copy link

mseminatore commented Jan 11, 2017

@mreinstein There seems to be a bug in the server generation of utterance permutations. For example the following:

"utterances": ['{to|} set temperature to {64-80|number}']

generates utterances as follows:

setTempsIntent	to set temperature to {sixty four|number}
setTempsIntent	set temperature to {sixty five|number}
setTempsIntent	to set temperature to {sixty six|number}
setTempsIntent	set temperature to {sixty seven|number}
...

but what I believe should be generated is:

setTempsIntent	to set temperature to {sixty four|number}
setTempsIntent	set temperature to {sixty four|number}
setTempsIntent	to set temperature to {sixty five|number}
setTempsIntent	set temperature to {sixty five|number}
setTempsIntent	to set temperature to {sixty six|number}
setTempsIntent	set temperature to {sixty six|number}
setTempsIntent	to set temperature to {sixty seven|number}
setTempsIntent	set temperature to {sixty seven|number}
...
@mseminatore
Copy link
Author

@mreinstein OK I've confirmed that the issue lies with not generating an exhaustive set of utterances not with the lib itself. I sent a PR with my test case which now passes. Maybe a useful addition maybe not.

@dblock
Copy link
Collaborator

dblock commented Jan 13, 2017

This issue as described is not one, I opened #19 for the real problem. Thanks for bringing this up @mseminatore.

@dblock dblock closed this as completed Jan 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants