Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

passport.js authentication #11

Open
quarhodron opened this issue Oct 5, 2019 · 1 comment
Open

passport.js authentication #11

quarhodron opened this issue Oct 5, 2019 · 1 comment

Comments

@quarhodron
Copy link

quarhodron commented Oct 5, 2019 •
edited
Loading

Hi!

What was the reason that you dropped the idea to authenticate with the help of passport.js (I saw your old branch)?

@alex996
@alex996
Copy link
Owner

alex996 commented Oct 30, 2019

Hi @quarhodron, and sorry for a late reply. I didn't see much benefit for this repo in using Passport. Also, one thing I didn't approve of is how deserializeUser is invoked on every authenticated request, even when you're only fetching e.g. messages or chats and don't need the user record at all. Perhaps I missed something and there's a way around that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alex996 @quarhodron