Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#164 broadcast change messages with descriptions #168

Draft
wants to merge 37 commits into
base: master
Choose a base branch
from

Conversation

alex-courtis
Copy link
Owner

@alex-courtis alex-courtis commented Apr 30, 2024

fixes #164

TODO:

  • failure messages, maybe separate config element
  • consider logging the deltas to files
  • default CHANGE_SUCCESS_CMD: notify-send way-displays "${WD_CHANGE_SUCCESS_MSG}"

@PaideiaDilemma
Copy link
Contributor

Hi alex!

I have been a bit busy, so I did not see this yet. But now I did :)

Have you thought about piping the changes directly to the stdin of the change command process?
This would have the benefit of not needing to create a file, but could be a bit harder to use I guess.

And more generally do you intend to write the change file all the time, or just when ON_CHANGE_COMMAND is set?

@alex-courtis
Copy link
Owner Author

Have you thought about piping the changes directly to the stdin of the change command process? This would have the benefit of not needing to create a file, but could be a bit harder to use I guess.

That's a great idea. I'll see if it's feasible.

And more generally do you intend to write the change file all the time, or just when ON_CHANGE_COMMAND is set?

That could be done; a pattern of file names / directory would need to be set to allow the user to poll / notify.

@alex-courtis alex-courtis force-pushed the 164-change-success-message branch from dfa42b6 to a0e1861 Compare September 2, 2024 04:57
@alex-courtis alex-courtis changed the title #164 write change success message to file #164 broadcast change messages with descriptions Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Additional CHANGE_SUCCESS_CMD Functionality
2 participants