Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hello World Example and Contributions? #43

Closed
jeffcampbellmakesgames opened this issue Feb 24, 2020 · 3 comments
Closed

Hello World Example and Contributions? #43

jeffcampbellmakesgames opened this issue Feb 24, 2020 · 3 comments

Comments

@jeffcampbellmakesgames
Copy link

Hi there, I am evaluating different open source node graph projects for Unity as the basis for other tools I'm writing, both internal and also open source. I like this one because the appearance matches the newer native Unity graph tools and that its available as a package (easy dependency management). I have a couple of questions for you when you have a chance:

  • Do you have a hello world example available somewhere that would demonstrate how to setup a basic graph? I see you have several screenshots on the readme demonstrating the nodes/graphs, but other than the WIP project linked here I'm not sure where to get started. I have followed some of the wiki instructions for creating nodes, graph views, but am not sure where to go from there.
  • If I ended up using this I'd like to help contribute bug fixes/features as I can; how do you want contributions to be made, do you have any particular style guide for code, and is Trello the main backlog source for this project?

Thanks!

@alelievr
Copy link
Owner

Hey,

Indeed this project uses the new API for graph visualization in Unity: GraphView as well as some recent C# features :)

Do you have a hello world example available somewhere

All the screenshots from the readme are avaliable in this project (Example folder), it also contains very simple implementation of graph like this one: https://github.com/alelievr/NodeGraphProcessor/tree/master/Assets/Examples/Editor/05_All which is a good starting point since it only have a toolbar and all basic graph functionality. As for asset management (open the graph when opening the asset), you can have a look at this file: https://github.com/alelievr/NodeGraphProcessor/blob/master/Assets/Examples/Editor/GraphAssetCallbacks.cs, it uses standard Unity API to open the graph window from the asset.
Mixture is a much more advanced project without any documentation so I wouldn't recommend it as starting point, but if you already know the API / code it can provide some useful examples (I still need to write the readme though)

If I ended up using this I'd like to help contribute bug fixes/features as I can

Every pull requests is welcomed :) I'll review them when i have some time to spend on the project.
I don't really enforces any coding convention, as long as the code is clean, commented and readable.
And for trello, i think i'll move most of it to a Github project to make issue tracking and feature requests more visible and accessible.

@jeffcampbellmakesgames
Copy link
Author

Hey,

Indeed this project uses the new API for graph visualization in Unity: GraphView as well as some recent C# features :)

Do you have a hello world example available somewhere

All the screenshots from the readme are avaliable in this project (Example folder), it also contains very simple implementation of graph like this one: https://github.com/alelievr/NodeGraphProcessor/tree/master/Assets/Examples/Editor/05_All which is a good starting point since it only have a toolbar and all basic graph functionality. As for asset management (open the graph when opening the asset), you can have a look at this file: https://github.com/alelievr/NodeGraphProcessor/blob/master/Assets/Examples/Editor/GraphAssetCallbacks.cs, it uses standard Unity API to open the graph window from the asset.
Mixture is a much more advanced project without any documentation so I wouldn't recommend it as starting point, but if you already know the API / code it can provide some useful examples (I still need to write the readme though)

Thanks for the heads up, I'll have to check that out. I've attempted to clone this repo and checkout the master branch, but strangely enough my GIT client has been crashing from what appears to be pulling the ShaderGraph submodule.

image

Is this submodule still needed? It appears that the code at that repo is no longer up-to-date and has moved to a separate repository.

image

If I ended up using this I'd like to help contribute bug fixes/features as I can

Every pull requests is welcomed :) I'll review them when i have some time to spend on the project.
I don't really enforces any coding convention, as long as the code is clean, commented and readable.
And for trello, i think i'll move most of it to a Github project to make issue tracking and feature requests more visible and accessible.

Sounds great, looking forward to it! 👍

@alelievr
Copy link
Owner

Is this submodule still needed? It appears that the code at that repo is no longer up-to-date and has moved to a separate repository.

I didn't see that there was still the old git submodule in this repo it's not used anymore. I just deleted it in 5889bc9, thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants