Skip to content

Commit 0fc2cff

Browse files
author
Andrew
committed
Handle each type separately
Due to the nature of accordions having every type housed inside a single one meant that closing one section closed the rest. However each type now has their own accordion with a unique ID.
1 parent dc2079e commit 0fc2cff

File tree

2 files changed

+18
-18
lines changed

2 files changed

+18
-18
lines changed

app/assets/javascripts/assets.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
function changeIconOnClick() {
2-
$('#accordion h5 a').click(function(e){
2+
$('h5 a').click(function(e){
33
var card = $(e.target).closest('div.card');
44
var img = $('i', card)[0];
55

app/views/assets/index.html.erb

Lines changed: 17 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -25,25 +25,26 @@
2525
</div>
2626
</div>
2727
<br>
28-
<div id="accordion" class="center w-25">
2928
<% if @assets and not @assets.empty? %>
3029
<% @assets.each do |type, assets| %>
31-
<div class="card mb-1">
32-
<div class="card-header">
33-
<h5 class="mb-0">
34-
<a data-toggle="collapse" href="#<%= type %>">
35-
<%= type.downcase.capitalize %>
36-
</a>
37-
<i class="fa fa-minus fa-pull-right mt-1"></i>
38-
</h5>
39-
</div>
30+
<div id="accordion-<%= type.downcase %>" class="center w-25">
31+
<div class="card mb-1">
32+
<div class="card-header">
33+
<h5 class="mb-0">
34+
<a data-toggle="collapse" href="#<%= type %>">
35+
<%= type.downcase.capitalize %>
36+
</a>
37+
<i class="fa fa-minus fa-pull-right mt-1"></i>
38+
</h5>
39+
</div>
4040

41-
<div id="<%= type %>" class="collapse show" data-parent="#accordion">
42-
<div class="card-body">
43-
<div class="list-group">
44-
<% assets.each do |a| %>
45-
<%= link_to a, assets_path + '/' + a, class: 'list-group-item list-group-item-action' %>
46-
<% end %>
41+
<div id="<%= type %>" class="collapse show" data-parent="#accordion-<%= type.downcase %>">
42+
<div class="card-body">
43+
<div class="list-group">
44+
<% assets.each do |a| %>
45+
<%= link_to a, assets_path + '/' + a, class: 'list-group-item list-group-item-action' %>
46+
<% end %>
47+
</div>
4748
</div>
4849
</div>
4950
</div>
@@ -52,5 +53,4 @@
5253
<% else %>
5354
No asset information found.
5455
<% end %>
55-
</div>
5656
</div>

0 commit comments

Comments
 (0)