Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider replacing Watcher with chokidar #105

Open
albe opened this issue May 31, 2020 · 0 comments
Open

Consider replacing Watcher with chokidar #105

albe opened this issue May 31, 2020 · 0 comments

Comments

@albe
Copy link
Owner

albe commented May 31, 2020

Though I try to avoid external dependencies where they do not solve a complex sub-task better than I could, https://github.com/paulmillr/chokidar could help handling the ReadOnly aspect better cross-platform. Especially on mac I have no actual idea how this behaves.

Drawbacks:

  • another dependency (though chokidar 3 stripped most of it's own dependencies, so that's good)
  • does much more than what is actually needed by this project - we only need to watch a specific folder consistently for file changes and renames
  • not sure how it handles creating lots of watchers internally

Benefits:

  • better support of change/rename events across platforms
  • deduplication of events
  • battle tested in a lot of big production projects
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant