-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
more rules candidates #9
Comments
Also |
Do we need to consider indent if we implement "max-len"? |
every rule should be standalone. that's means it could not depend on rule related issue: eslint/eslint#11325 |
If we implement "max-len", I think I don't need to use Prettier in other projects any more. |
Should we add autofix for "no-unreachable"? |
Does no-async-promise-executor need to be fixed? |
not very sure about no-async-promise-executor. :( |
我们不妨去 ESLint 的列表找找哪些规则还没有 autofix 的,然后看看哪些值得去实现,接着在这个 repo 针对每个规则单独开 issue 进行讨论(实现思路),如果讨论没问题就打个 accepted 的 label,如果思路不可行就直接关闭掉 issue。你怎么看? |
可以,优先考虑在 eslint:recommended 中的规则 |
我不确定还要不要实现 |
refs: eslint/eslint#11542 |
How about |
@mekwall sounds good to me! |
Someone implemented sort-keys but it was a year ago https://www.npmjs.com/package/eslint-plugin-sort-keys-fix |
any updates on max-len? |
Please add max-len. Its the only thing holding me (and it seems others) back from throwing Prettier out … |
The text was updated successfully, but these errors were encountered: