diff --git a/generator.go b/generator.go index 0aa1204..cd82d94 100644 --- a/generator.go +++ b/generator.go @@ -10,24 +10,13 @@ import ( const LETTERS = "abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789-._~" // GenerateRandomString returns a random string of a given length -func GenerateRandomString(l int) (string, error) { +func GenerateRandomString(l int) string { builder := strings.Builder{} builder.Grow(l) for i := 0; i < l; i++ { - number, err := generateRandomNumber() - if err != nil { - return "", err - } - builder.WriteString(string(LETTERS[number])) + n, _ := rand.Int(rand.Reader, big.NewInt(56)) + builder.WriteString(string(LETTERS[n.Int64()])) } - return builder.String(), nil -} - -func generateRandomNumber() (int64, error) { - n, err := rand.Int(rand.Reader, big.NewInt(56)) - if err != nil { - return 0, err - } - return n.Int64(), nil + return builder.String() } diff --git a/generator_test.go b/generator_test.go index 54ce7f8..0590e7c 100644 --- a/generator_test.go +++ b/generator_test.go @@ -7,8 +7,6 @@ import ( ) func TestGenerateRandomString(t *testing.T) { - randomString, err := GenerateRandomString(128) - if assert.Nil(t, err) { - assert.Equal(t, 128, len(randomString)) - } + randomString := GenerateRandomString(128) + assert.Equal(t, 128, len(randomString)) } diff --git a/pkce.go b/pkce.go index ddd0285..02f6495 100644 --- a/pkce.go +++ b/pkce.go @@ -31,10 +31,7 @@ func (p *Pkce) VerifyCode() (string, error) { return "", errors.New("length should be >=43 and <=128") } - randomString, err := GenerateRandomString(p.Length) - if err != nil { - return "", err - } + randomString := GenerateRandomString(p.Length) p.RandomString = randomString return randomString, nil } else {