Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zap #49

Open
wants to merge 15 commits into
base: development
Choose a base branch
from
Open

Zap #49

wants to merge 15 commits into from

Conversation

joshualyguessennd
Copy link
Member

Submitter Checklist:

  • All unittests within the repository pass.
  • All code has been properly linted.
  • All commit messages conform to commit-lint specification, i.e. type(scope?): subject
  • A slither report has been created with slither analyze and I have amended appropriate issues. If I have not amended an issue I have provided justification as to why in a comment on this PR.
  • Upgradeability has been checked with slither-check-upgradeability.
  • ERC conformity has been checked with slither-check-erc.
  • Test coverage is at least 90%.
  • The contracts have been reviewed for basic best practices, as outlined here: Recommendations and Known Attacks.
  • If necessary, I confirm that the Echidna tests pass.
  • If necessary, I confirm that the Manticore tests pass.
  • Ran git rebase master (if appropriate)
  • I have registered the PR on Jira and informed the team

Reviewer Checklist:

  • All unittests are passing and coverage is appropriate.
  • The slither report produced has been reviewed and the justifications for ignoring certain issues are reasonable.
  • A second reviewer is needed.
  • Major changes are well commented.
  • Next steps are outlined in the PR.

After-merge Checklist:

  • Jira has been updated to show the completion of this task (if appropriate).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant