Skip to content
This repository has been archived by the owner on Nov 15, 2022. It is now read-only.

Start in a non-git directory takes about 400ms #799

Open
plafue opened this issue Oct 15, 2019 · 2 comments
Open

Start in a non-git directory takes about 400ms #799

plafue opened this issue Oct 15, 2019 · 2 comments

Comments

@plafue
Copy link

plafue commented Oct 15, 2019

When opening atom in a directory that is not a git repository, git-plus takes substantial time to activate. These are the samples taken when opening atom in an empty directory: 318ms, 388ms, 416ms, 405ms, 418ms, 566ms, 399ms, 395ms, 415ms, 400ms.

In comparison, opening atom with git-plus in a git repository takes always under 10ms.

I'm running atom 1.40.1 with git-plus 8.7.1 under Linux.

Steps to reproduce:

  1. mkdir git-plus-empty-test && cd git-plus-empty-test
  2. atom .
  3. Open timecop
@akonwi
Copy link
Owner

akonwi commented Oct 17, 2019

Whoa, that's really weird. Yea that's consistent on my computer too.

I just profiled the actual execution of this package's activation, it only takes at most 4ms in any window, regardless of whether there are any folders/repositories even though timecop reports a much bigger number. I'll have to investigate more but I imagine it's some of the auxillary stuff atom does around the package activation that might be padding the numbers.

@plafue
Copy link
Author

plafue commented Oct 17, 2019

Thanks for looking into this!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants